os.Readdirnames should return 0, os.EOF at eof

[rsc]

instead it returns 0, nil right now.
not sure if behavior should change depending
on whether arg was "read all" or "read n".

[bradfitz]

Comment 1:

Russ, I could take this and audit uses in the tree if you decide on the desired behavior.

[rsc]

Comment 2:

I think it should return 0, os.EOF but only when n > 0.
That is, when n < 0 (or is it n <= 0, whatever is documented)
it should be like ioutil.ReadAll; when n > 0 it should be like Read.
The problem is that we combined them.

[bradfitz]

Comment 3:

Current docs say:
func (file *File) Readdirnames(count int) (names []string, err Error)
Readdirnames returns an array of up to count file names residing in the directory
associated with file. A negative count will return all of them. Readdir returns the
array and an Error, if any.
-------
Do you only want 0, os.EOF returned at the end of the stream of N > 0 calls, or can
Readdirnames(5) return (len([]string) == 4, os.EOF)?
Proposed new docs?

[rsc]

Comment 4:

// Readdirnames reads and returns a slice of names from the directory f.
// If n > 0, Readdirnames returns at most n names.
// In this case, if Readdirnames returns an empty slice, it will return
// a non-nil error explaining why.  At the end of a directory, the
error is os.EOF.
// If n <= 0, Readdirnames returns all the names from
// the directory in a single slice.  In this case, if Readdirnames succeeds
// (reads all the way to the end of the directory),
// it returns the slice and a nil os.Error.  If it encounters an error
// before the end of the directory, Readdirnames returns the names
// read until that point and a non-nil error.
func (f *File) Readdirnames(n int) (names []string, err os.Error)

[bradfitz]

Comment 5:

Owner changed to @bradfitz.

[bradfitz]

Comment 6:

This issue was closed by revision 4da5cd4.

Status changed to Fixed.