Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: enable telemetry prompting for all editors #67821

Open
hyangah opened this issue Jun 4, 2024 · 2 comments
Open

x/tools/gopls: enable telemetry prompting for all editors #67821

hyangah opened this issue Jun 4, 2024 · 2 comments
Assignees
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Jun 4, 2024

Gopls's telemetry prompting is currently disabled by default.
Client should enable by either setting an internal setting or by calling the prompt command.
VS Code Go extension calls the command for the user selected based on
the hash of vscode client id, after at least a week has passed since a telemetry-enabled
gopls version runs. We now want to move this sampling and decision making to gopls, too,
and enable the prompting in all editors, not only in vscode.

That means we need to record more info in the prompt file in the gopls config directory.

Requirement:

  • Preserve the info recorded in the prompt file and avoid prompting users again.
  • Do not prompt if the user just started to use gopls. Wait for 1 week.

Some nice-to-haves:

  • VS Code Go extension had been running it for awhile. For consistency in sampling, let gopls use the same hash for vs code users.
  • If possible, migrate the telemetry start time recorded in the VS Code Go extension's memento.
@hyangah hyangah added this to the gopls/v0.17.0 milestone Jun 4, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 4, 2024
@hyangah hyangah self-assigned this Jun 4, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/589517 mentions this issue: gopls/internal/server: conditionally prompt for telemetry

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/589836 mentions this issue: internal/settings: prompt for telemetry by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants