x/benchmarks/sweet/benchmarks/etcd: doesn't build on Plan 9 #68287
Description
Go version
gotip
Output of go env in your module/workspace:
GOARCH=arm
GOBIN=
GOCACHE=/home/swarming/.swarming/w/ir/x/w/gocache
GOHOSTARCH=amd64
GOHOSTOS=linux
GOMAXPROCS=4
GOOS=plan9
GOPATH=/home/swarming/.swarming/w/ir/x/w/gopath
GOPLSCACHE=/home/swarming/.swarming/w/ir/x/w/goplscache
GOROOT=
GOROOT_BOOTSTRAP=/home/swarming/.swarming/w/ir/cache/tools/go_bootstrap
GOTOOLCHAIN=local
GO_BUILDER_NAME=x_benchmarks-gotip-plan9-armWhat did you do?
In x/benchmarks, builder attempted to run go test -json -short ./...
What did you see happen?
# github.com/coreos/go-systemd/v22/journal
../gopath/pkg/mod/github.com/coreos/go-systemd/v22@v22.3.2/journal/journal_unix.go:120:20: undefined: syscall.UnixRights
../gopath/pkg/mod/github.com/coreos/go-systemd/v22@v22.3.2/journal/journal_unix.go:180:31: undefined: syscall.EMSGSIZE
../gopath/pkg/mod/github.com/coreos/go-systemd/v22@v22.3.2/journal/journal_unix.go:180:65: undefined: syscall.ENOBUFS
../gopath/pkg/mod/github.com/coreos/go-systemd/v22@v22.3.2/journal/journal_unix.go:189:16: undefined: syscall.Unlink
FAIL golang.org/x/benchmarks/sweet/benchmarks/etcd [build failed]
What did you expect to see?
Expected tests to be skipped. The x/benchmark tests are only being run on Plan 9 under the new LUCI infrastructure; the old coordinator didn't send them to Plan 9 builders. The etcd test in particular is related to systemd and clearly has no relevance to Plan 9. I suggest adding a !plan9 build tag to etcd/main.go.