Skip to content

x/tools/gopls/internal/cmd: TestCodeLens failures #68506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jul 18, 2024 · 3 comments
Closed

x/tools/gopls/internal/cmd: TestCodeLens failures #68506

gopherbot opened this issue Jul 18, 2024 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestCodeLens"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestCodeLens
=== PAUSE TestCodeLens
=== CONT  TestCodeLens

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 18, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 18, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jul 18, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestCodeLens"
2024-07-16 16:13 x_tools-go1.23-windows-amd64-race tools@25ed04f2 release-branch.go1.23@30b6fd60 x/tools/gopls/internal/cmd.TestCodeLens [ABORT] (log) 
=== RUN   TestCodeLens
=== PAUSE TestCodeLens
=== CONT  TestCodeLens

— watchflakes

@hyangah
Copy link
Contributor

hyangah commented Jul 18, 2024

Looks like the same root cause of #54461
(the log message has the error message about this hanging go command issue)

@hyangah hyangah modified the milestones: Unreleased, gopls/backlog Jul 18, 2024
@adonovan
Copy link
Member

I agree; closing as dup of #54461.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
gopls/backlog
Development

No branches or pull requests
3 participants
@hyangah @adonovan @gopherbot