Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: windows arm32 1.22 broken #68996

Closed
wmjb opened this issue Aug 21, 2024 · 4 comments
Closed

runtime: windows arm32 1.22 broken #68996

wmjb opened this issue Aug 21, 2024 · 4 comments
Assignees
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Milestone

Comments

@wmjb
Copy link

wmjb commented Aug 21, 2024

Go version

1.22

commit 4beb330 breaks go building on windows arm32

What did you do?

fixed it by putting back (accidentally?) removed line 238 in src/runtime/sys_windows_arm.s
MOVW $_INTERRUPT_TIME, R3

What did you see happen?

when using this fix #68552 (comment) and the fix to sys_windows_arm.s above, go now builds up to 1.23 and functions correctly for windows arm32.

What did you expect to see?

all is well with go and with these fixes can be unmarked broken for windows arm32

@ianlancetaylor ianlancetaylor changed the title runtime arm32 1.22 broken runtime: windows arm32 1.22 broken Aug 21, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 21, 2024
@ianlancetaylor
Copy link
Member

CC @golang/windows @qmuntal

@qmuntal
Copy link
Member

qmuntal commented Aug 21, 2024

Good catch, that line shouldn't have been removed. @wmjb do you want to send a CL with the fix? Else I can do it myself.

@wmjb
Copy link
Author

wmjb commented Aug 21, 2024

Good catch, that line shouldn't have been removed. @wmjb do you want to send a CL with the fix? Else I can do it myself.

can you take care of that. thank you.

@mknyszek mknyszek added this to the Backlog milestone Aug 21, 2024
@mknyszek mknyszek added NeedsFix The path to resolution is known, but the work has not been done. arch-arm Issues solely affecting the 32-bit arm architecture. labels Aug 21, 2024
@qmuntal qmuntal self-assigned this Aug 22, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/607776 mentions this issue: runtime: fix nanotime1 on windows/arm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Projects
Development

No branches or pull requests

5 participants