-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: disabling telemetry causes telemetry files to be written #69269
Labels
Milestone
Comments
dmitshur
added
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
GoCommand
cmd/go
labels
Sep 5, 2024
CC @matloob, @samthanawalla, @findleyr. |
Once |
Change https://go.dev/cl/611456 mentions this issue: |
dmitshur
added
NeedsFix
The path to resolution is known, but the work has not been done.
and removed
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
labels
Sep 9, 2024
Change https://go.dev/cl/611876 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Sep 9, 2024
The telemetry script test checks for the existence of telemetry data as a baseline before checking that the act of setting telemtetry to off while in local mode doesn't produce telemetry data. Of course, when we're running on platforms where telemetry is not supported, telemetry data won't be produced on disk either way. Only check for the existence of telemetry data on supported platforms. For #69269 Change-Id: I3a06bbc3d3ca0cf0203b84883f632ecfd9445aae Reviewed-on: https://go-review.googlesource.com/c/go/+/611876 Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Michael Matloob <matloob@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Go version
go version go1.23.0 linux/amd64
Output of
go env
in your module/workspace:What did you do?
go telemetry off
ls $HOME/.config/go/telemetry/local
What did you see happen?
I saw telemetry data in this directory:
What did you expect to see?
I expected that this directory would be nonexistent since I have never before run a go command with this home directory, except for a command that expresses my desire to have telemetry disabled.
This wouldn't be an issue if telemetry could be disabled with an environment variable (#68960), and it would be less of an issue if telemetry data were written to a more appropriate location (#68988).
The text was updated successfully, but these errors were encountered: