reflect: remove calling mapiterkey and mapiterelem

[xiaost]

Hi, Go team.

I'm working on optimizing iterating over map for an internal data encoding project.
And in our case, I found that one of the bottlenecks is reflect.MapIter .Next.
It can be improved by removing calling mapiterkey.

coz we have already copiedhiter struct from runtime for performance concern.
To make it further, we can use key and elem of hiter struct directly without calling mapiterkey and mapiterelem

This mainly impacts the Next method of reflect.MapIter.
I ran the BenchmarkMapIterNext benchmark in reflect/benchmark_test.go, and here is the output:

goos: darwin
goarch: arm64
pkg: reflect
cpu: Apple M2 Pro
               │  ./old.txt  │              ./new.txt              │
               │   sec/op    │   sec/op     vs base                │
MapIterNext-12   61.44n ± 1%   54.51n ± 1%  -11.29% (p=0.000 n=10)

I would like to raise CR if you're OK with it.

[gabyhelp]

Related Issues and Documentation

• reflect: add MapIter.SetKey, SetValue, and friends #46131 (closed)
• proposal: reflect: add direct MapIter accessors #66125 (closed)
• reflect: add MapIter.Reset #46293 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[earthboundkid]

In general, performance improvements with no user visible effect can just be submitted. A proposal doesn't need to be approved first unless it's doing something unusual to get the performance.

[gopherbot]

Change https://go.dev/cl/612616 mentions this issue: reflect: remove calling mapiterkey, mapiterelem

[ianlancetaylor]

Taking this out of the proposal process.

[gopherbot]

Change https://go.dev/cl/613395 mentions this issue: reflect: allow inlining mapiterkey/mapiterelem