Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: possible PGO miscompilation in biogo-igor benchmark #69614

Open
mknyszek opened this issue Sep 24, 2024 · 3 comments
Open

cmd/compile: possible PGO miscompilation in biogo-igor benchmark #69614

mknyszek opened this issue Sep 24, 2024 · 3 comments
Assignees
@prattmic
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@mknyszek
Copy link
Contributor

The biogo-igor benchmark part of Sweet has been failing regularly at tip in the end-to-end test. It specifically fails when being run under PGO.

Broken out from #56958.
@mknyszek
Copy link
Contributor Author

CC @golang/compiler

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 24, 2024
@mknyszek
Copy link
Contributor Author

Example failure looks like:

error: piling: record on line 0; parse error on line 1, column 3: strconv.ParseInt: parsing "16243440": value out of range

2024-09-20 15:27 x_benchmarks-gotip-linux-amd64-longtest benchmarks@b8e725b7 go@c208b913 x/benchmarks/sweet/cmd/sweet.TestSweetEndToEnd (log)

gopherbot pushed a commit to golang/benchmarks that referenced this issue Sep 24, 2024
@mknyszek
sweet: remove biogo benchmarks from default set
7f91281 
These benchmarks have shown themselves to not be of a lot of use over
time. They tend to exhibit pathological behaviors not visible in other
programs, that could be worked around if the benchmarks themselves were
improved. Note that these benchmarks are, in part, written by us, using
the biogo library.

biogo-igor is also causing flaky test failures, so this CL skips them for
the end-to-end test, though we think it might be a real PGO bug.

Let's drop them at this point. We'll add back something more interesting
very soon.

Fixes golang/go#56958.
Updates golang/go#69614.

Change-Id: Ic3761953abf4c8db19b3623e135a809c841cf160
Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/615416
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/615416 mentions this issue: sweet: remove biogo benchmarks from default set

@mknyszek mknyszek added this to the Backlog milestone Sep 25, 2024
@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prattmic prattmic

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Compiler / Runtime
Status: Todo
Milestone
Backlog
Development

No branches or pull requests
3 participants
@mknyszek @prattmic @gopherbot