x/tools/gopls/internal/cache: TestZeroConfigAlgorithm/basic_GOPATH_workspace failed in my ubuntu

[xieyuschen]

Go version

gotip

Output of go env in your module/workspace:

GO111MODULE='on'
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/xieyuschen/.cache/go-build'
GOENV='/home/xieyuschen/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/xieyuschen/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/xieyuschen/go'
GOPRIVATE=''
GOPROXY='https://goproxy.cn,direct'
GOROOT='/home/xieyuschen/sdk/gotip'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/xieyuschen/sdk/gotip/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='devel go1.24-8cd550a Fri Sep 6 13:49:31 2024 +0000'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/home/xieyuschen/.config/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/home/xieyuschen/codespace/go-tools/gopls/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build4024255374=/tmp/go-build -gno-record-gcc-switches'

What did you do?

$ git clone git@github.com:golang/tools.git --depth 1 && cd tools
$ git rev-parse HEAD
27e1a3a221b2f5da3ea02dc9bb70c6b71c787551
$ uname -a
Linux xieyuschen 6.8.0-48-generic #48~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC 
Mon Oct  7 11:24:13 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
$ cd gopls
$ gotip clean --testcache && gotip test ./internal/cache -run=TestZeroConfigAlgorithm -v

What did you see happen?

=== RUN   TestZeroConfigAlgorithm/basic_GOPATH_workspace
    session_test.go:373: selectViews() mismatch (-want +got):
          []cache.viewSummary{
          	{
        - 		Type: s"GOPATH",
        + 		Type: s"AdHoc",
          		Root: "src",
          		Env:  nil,
          	},
        + 	{Type: s"AdHoc", Root: "src/golang.org/a"},
        + 	{Type: s"AdHoc", Root: "src/golang.org/b"},
          }

What did you expect to see?

The test should pass.

[gabyhelp]

Related Issues and Documentation

• x/tools/gopls/test/debug: test fails when run in the module cache #59841 (closed)
• runtime/debug: TestStack fail #65506 (closed)
• x/tools/gopls/internal/cache: TestZeroConfigAlgorithm failing on `wasm` builders #65271 (closed)
• x/tools/cmd/gopls: Go to definition failed on vscode-remote ssh #33683 (closed)
• go env #65011 (closed)
• x/tools/internal/modindex: TestIncremental failures #70121 (closed)
• error gopath #66295 (closed)
• cmd/go: git tip fails to pass all.bash's build-time tests on Fedora 27 from commit afd090c0 #23337 (closed)
• x/tools/gopls/internal/regtest/diagnostic: TestMultipleModules_Warning consistently fails when run locally with a 'go' build from head #45866 (closed)
• x/tools/gopls: workspace symbols jumps to incorrect location with files with CGO #37659 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/625415 mentions this issue: gopls/internal/cache: log go env in TestZeroConfigAlgorithm

[xieyuschen]

Hi @rfindley, this is the log after i try bba76372, and thanks for your help:)

$ git rev-parse HEAD
bba763728da3c5798c72b76c57400998049bc33f
$ pwd
/home/xieyuschen/codespace/tools/gopls
$ gotip clean --testcache && gotip test ./internal/cache -run=TestZeroConfigAlgorithm -v

=== RUN   TestZeroConfigAlgorithm/basic_GOPATH_workspace
    session_test.go:348: FetchGoEnv("file:///tmp/TestZeroConfigAlgorithmbasic_GOPATH_workspace1534453248/001/src") = &{GOOS:linux GOARCH:amd64 GOCACHE:/home/xieyuschen/.cache/go-build GOMODCACHE:/tmp/TestZeroConfigAlgorithmbasic_GOPATH_workspace1534453248/001/pkg/mod GOPATH:/tmp/TestZeroConfigAlgorithmbasic_GOPATH_workspace1534453248/001 GOPRIVATE: GOFLAGS: GO111MODULE:on GOTOOLCHAIN:auto GOROOT:/home/xieyuschen/sdk/gotip GoVersion:24 GoVersionOutput:go version devel go1.24-8cd550a Fri Sep 6 13:49:31 2024 +0000 linux/amd64
         ExplicitGOWORK: EffectiveGOPACKAGESDRIVER:}
    session_test.go:375: selectViews() mismatch (-want +got):
          []cache.viewSummary{
          	{
        - 		Type: s"GOPATH",
        + 		Type: s"AdHoc",
          		Root: "src",
          		Env:  nil,
          	},
        + 	{Type: s"AdHoc", Root: "src/golang.org/a"},
        + 	{Type: s"AdHoc", Root: "src/golang.org/b"},
          }

[findleyr]

Thanks @xieyuschen. I added a new log message that can help debug. Can you sync to master and rerun this test, sharing the new log ("FetchGoEnv...")

[xieyuschen]

hi @findleyr , this is the failure log in e5417d7d9f

=== RUN   TestZeroConfigAlgorithm/basic_GOPATH_workspace
    session_test.go:348: FetchGoEnv("file:///tmp/TestZeroConfigAlgorithmbasic_GOPATH_workspace2524377415/001/src") = &{GOOS:linux GOARCH:amd64 GOCACHE:/home/xieyuschen/.cache/go-build GOMODCACHE:/tmp/TestZeroConfigAlgorithmbasic_GOPATH_workspace2524377415/001/pkg/mod GOPATH:/tmp/TestZeroConfigAlgorithmbasic_GOPATH_workspace2524377415/001 GOPRIVATE: GOFLAGS: GO111MODULE:on GOTOOLCHAIN:auto GOROOT:/home/xieyuschen/sdk/gotip GoVersion:24 GoVersionOutput:go version devel go1.24-8cd550a Fri Sep 6 13:49:31 2024 +0000 linux/amd64
         ExplicitGOWORK: EffectiveGOPACKAGESDRIVER:}
    session_test.go:375: selectViews() mismatch (-want +got):
          []cache.viewSummary{
          	{
        - 		Type: s"GOPATH",
        + 		Type: s"AdHoc",
          		Root: "src",
          		Env:  nil,
          	},
        + 	{Type: s"AdHoc", Root: "src/golang.org/a"},
        + 	{Type: s"AdHoc", Root: "src/golang.org/b"},
          }

[gopherbot]

Change https://go.dev/cl/625515 mentions this issue: gopls/internal/cache: ensure GO111MODULE is unset in GOPATH tests

[findleyr]

Perfect, thank you. I see that you have GO111MODULE set, which is causing the test to fail as GO111MODULE=on disables GOPATH.

CL incoming to fix the test environment.