runtime/pprof: TestCPUProfileMultithreaded flaky

[randall77]

An overnight run of repeated all.bash shows this test to be flaky.

    pprof_test.go:148: crc32.ChecksumIEEE has 9 samples out of 66, want at least 11, ideally 33
    pprof_test.go:148: crc32.ChecksumIEEE has 10 samples out of 68, want at least 11, ideally 34
    pprof_test.go:148: crc32.ChecksumIEEE has 10 samples out of 66, want at least 11, ideally 33
    pprof_test.go:148: crc32.ChecksumIEEE has 7 samples out of 65, want at least 10, ideally 32
    pprof_test.go:148: crc32.Update has 9 samples out of 69, want at least 11, ideally 34
    pprof_test.go:148: crc32.Update has 9 samples out of 66, want at least 11, ideally 33
    pprof_test.go:148: crc32.Update has 6 samples out of 66, want at least 11, ideally 33
    pprof_test.go:148: crc32.Update has 6 samples out of 65, want at least 10, ideally 32
    pprof_test.go:148: crc32.ChecksumIEEE has 9 samples out of 68, want at least 11, ideally 34
    pprof_test.go:148: crc32.ChecksumIEEE has 9 samples out of 66, want at least 11, ideally 33
    pprof_test.go:148: crc32.ChecksumIEEE has 8 samples out of 66, want at least 11, ideally 33
    pprof_test.go:148: crc32.Update has 10 samples out of 70, want at least 11, ideally 35
    pprof_test.go:148: crc32.Update has 10 samples out of 68, want at least 11, ideally 34
    pprof_test.go:148: crc32.Update has 8 samples out of 65, want at least 10, ideally 32
    pprof_test.go:148: crc32.ChecksumIEEE has 2 samples out of 65, want at least 10, ideally 32
    pprof_test.go:148: crc32.ChecksumIEEE has 3 samples out of 66, want at least 11, ideally 33
    pprof_test.go:148: crc32.Update has 10 samples out of 68, want at least 11, ideally 34
    pprof_test.go:148: crc32.Update has 9 samples out of 65, want at least 10, ideally 32
    pprof_test.go:148: crc32.Update has 8 samples out of 65, want at least 10, ideally 32
    pprof_test.go:148: crc32.Update has 6 samples out of 68, want at least 11, ideally 34
    pprof_test.go:148: crc32.ChecksumIEEE has 9 samples out of 66, want at least 11, ideally 33
    pprof_test.go:148: crc32.Update has 10 samples out of 66, want at least 11, ideally 33

[randall77]

Comment 1:

This issue was closed by revision cefe6ac.

Status changed to Fixed.

[RLH]

Another overnight run lasted for 11 hours of running all.bash repeatedly. Lots of local changes that could be the problem. Then I hit this again on a clean system I'll reopen. If I see a repeat I'll reopen.

ok runtime/debug 0.023s
--- FAIL: TestCPUProfileMultithreaded (0.25s)
pprof_test.go:166: runtime/pprof_test.cpuHog1: 49
pprof_test.go:166: runtime/pprof_test.cpuHog2: 0
pprof_test.go:180: runtime/pprof_test.cpuHog2 has 0 samples out of 49, want at least 1, ideally 24
FAIL
FAIL runtime/pprof 6.872s
? runtime/race [no test files]