x/tools/gopls: "nil handle" assert in getPackageHandles

[adonovan]

#!stacks
"cache.assert" && "getPackageHandles:+93"

Issue created by stacks.

	// Copy handles into the result map.
	handles := make(map[PackageID]*packageHandle, len(b.nodes))
	for _, v := range b.nodes {
		assert(v.ph != nil, "nil handle")  <--- here
		handles[v.mp.ID] = v.ph
	}

This stack DcqCUg was reported by telemetry:

• crash/crash
• runtime.gopanic:+69
• golang.org/x/tools/gopls/internal/cache.assert:=10
• golang.org/x/tools/gopls/internal/cache.(*Snapshot).getPackageHandles:+93
• golang.org/x/tools/gopls/internal/cache.(*Snapshot).forEachPackage:+37
• golang.org/x/tools/gopls/internal/cache.(*Snapshot).PackageDiagnostics:+28
• golang.org/x/tools/gopls/internal/server.(*server).diagnoseChangedFiles:+50
• golang.org/x/tools/gopls/internal/server.(*server).diagnoseSnapshot:+14
• golang.org/x/tools/gopls/internal/server.(*server).diagnoseChangedViews.func1:+3
• golang.org/x/tools/gopls/internal/server.(*server).diagnoseChangedViews.gowrap1:+16
• runtime.goexit:+0

golang.org/x/tools/gopls@v0.17.1 go1.23.4 linux/amd64 vscode (1)

[gabyhelp]

Related Issues

• x/tools/gopls: "nil metadata for %q" panic in Snapshot.getPackageHandles (reported by telemetry) #66144
• x/tools/gopls: "missing reachable node for %q" bug in evaluatePackageHandle #71352
• x/tools/gopls: nil deref in evaluatePackageHandle (telemetry) #69236 (closed)
• x/tools/gopls: analysisinternal.ZeroValue crash on (presumably) unsafe.Pointer #70585 (closed)
• x/tools/gopls: CodeAction: nil panic in findMatchingDiagnostics #71028 (closed)
• x/tools/gopls: crash in Hover (telemetry) #69362
• x/tools/gopls: panic in token.File.Name within PackageDocHTML (telemetry) #70149 (closed)
• x/tools/gopls: automated issue report (crash) #66174 (closed)
• x/tools/gopls: Hover: nil deref in parseDocLink #70635 (closed)
• x/tools/gopls: crash in packageReferences (reported by telemetry) #66250 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}