cmd/8g: internal compiler error when "-S" flag is used

[gopherbot]

by lubos.pintes:

What steps will reproduce the problem?
If possible, include a link to a program on play.golang.org.
1. go tool 8g -S a.go
2.
3.

What is the expected output?
The assembly listing of specified file.

What do you see instead?
Several lines of assembler output and then:
a.go:1: internal compiler error: fault

Which compiler are you using (5g, 6g, 8g, gccgo)?
8g

Which operating system are you using?
Windows 7 64-bit

Which version are you using?  (run 'go version')
go version devel +3a08deffa322 Tue Jan 21 13:06:57 2014 +0400 windows/386

Please provide any additional information below.

[ianlancetaylor]

Comment 1:

The bug report has no test case, but I see this for a simple hello, world program.

Labels changed: added release-go1.3, repo-main.

Owner changed to @rsc.

[robpike]

Comment 2:

This code is in cmd/6g:Dconv:
        case D_BRANCH:
        if(a->u.branch == nil)
            snprint(str, sizeof(str), "<nil>");
        else
            snprint(str, sizeof(str), "%d", a->u.branch->loc);
8g was missing the nil check. I've added that code to 8g, but now in both compilers all
branch targets print as "<nil>", so something is still broken.

[robpike]

Comment 3:

This issue was updated by revision 289d463.

LGTM=dave, iant
R=iant, dave
CC=golang-codereviews
https://golang.org/cl/58400043

[davecheney]

Comment 4:

Status changed to Accepted.

[ality]

Comment 5:

This issue was closed by revision 2cae059.

Status changed to Fixed.