Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/objdump: add arm disassembler #7452

Closed
cookieo9 opened this issue Mar 3, 2014 · 11 comments
Closed

cmd/objdump: add arm disassembler #7452

cookieo9 opened this issue Mar 3, 2014 · 11 comments
Assignees
Milestone

Comments

@cookieo9
Copy link
Contributor

@cookieo9 cookieo9 commented Mar 3, 2014

On darwin, running the list command in pprof produces an error from the go-supplied
objdump. Weblist is similarly affected.

What steps will reproduce the problem?
If possible, include a link to a program on play.golang.org.
1. Create code to be profiled (eg: http://play.golang.org/p/wW7KHrZQyB)
2. Profile it (go test -bench . -memprofile mem.prof)
3. Load the profile in pprof (go tool pprof --alloc_space alloc.test mem.profile)
4. Try to get a listing of a function (list alloc.BenchmarkAlloc)

What is the expected output?
A code listing w/ profile data for each line.

What do you see instead?
objdump: syminit: Undefined error: 0
no filename found in _/Users/cookieo9/alloc.BenchmarkAlloc<3c040>

Which operating system are you using?
Mac OS X 10.9.2 (darwin/amd64)

Which version are you using?  (run 'go version' or 'gccgo --version')
go version devel +7257b771f12b Mon Mar 03 11:25:57 2014 -0800 darwin/amd64 (tip)

Go 1.2.1 (homebrew) works, tip does not. I believe it has something to do with one of
the changes to address https://golang.org/issue/6853 and objdump
hasn't been brought up-to date.
@rsc
Copy link
Contributor

@rsc rsc commented Mar 4, 2014

Comment 1:

This is a known problem; I need to rewrite objdump in Go to make it work again

Labels changed: added release-go1.3.

Status changed to Started.

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 14, 2014

Comment 3:

CL https://golang.org/cl/87580043 mentions this issue.
@rsc
Copy link
Contributor

@rsc rsc commented Apr 14, 2014

Comment 4:

This issue was updated by revision 0d441a0.

This is the basic logic needed for objdump, and it works well enough
to support the pprof list and weblist commands. A real disassembler
needs to be added in order to support the pprof disasm command
and the per-line assembly displays in weblist. That's still to come.
Probably objdump will move to go.tools when the disassembler
is added, but it can stay here for now.
LGTM=minux.ma
R=golang-codereviews, minux.ma
CC=golang-codereviews, iant, r
https://golang.org/cl/87580043
@gopherbot
Copy link

@gopherbot gopherbot commented May 14, 2014

Comment 5:

CL https://golang.org/cl/91360046 mentions this issue.
@rsc
Copy link
Contributor

@rsc rsc commented May 14, 2014

Comment 6:

This issue was updated by revision 79fb16d.

x86 disassembly works and is tested.
The arm disassembler does not exist yet
and is therefore not yet hooked up.
LGTM=crawshaw, iant
R=crawshaw, iant
CC=golang-codereviews
https://golang.org/cl/91360046
@davecheney
Copy link
Contributor

@davecheney davecheney commented May 15, 2014

Comment 7:

Would you like to see ARM disassembly added for 1.3, or is it too late ?
@rsc
Copy link
Contributor

@rsc rsc commented May 28, 2014

Comment 8:

Replying to #7, it's on its way.
@davecheney
Copy link
Contributor

@davecheney davecheney commented May 28, 2014

Comment 9:

@rsc, aram and I are happy to help fill in the gaps if you have the beginnings of a CL.
@rsc
Copy link
Contributor

@rsc rsc commented May 28, 2014

Comment 10:

Owner changed to @rsc.

@gopherbot
Copy link

@gopherbot gopherbot commented May 31, 2014

Comment 11:

CL https://golang.org/cl/104770046 mentions this issue.
@rsc
Copy link
Contributor

@rsc rsc commented Jun 1, 2014

Comment 12:

This issue was closed by revision 9f2dfb8.

Status changed to Fixed.

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
Fixes golang#7452.

LGTM=minux, iant
R=minux, iant
CC=golang-codereviews
https://golang.org/cl/104770046
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants