x/tools: 245 occurrences of fmt.Errorf with no formatting

[AlexsanderHamir]

I was working on #74378 and noticed many instances of fmt.Errorf being used without formatting. I wrote a small script to replace these with errors.New, ensuring the errors package is imported correctly. All tests pass after the change. I imagine this hasn’t been done before because it’s not important enough, but if the project maintainers think it’s worthwhile, I’d be happy to submit the changes.

[adonovan]

Thanks for offering. However, the consensus has long been that it is acceptable to use fmt.Errorf instead of errors.New; I for one never point it out in code reviews. The dynamic cost of the degenerate Printf operation is essentially negligible since error paths are infrequently executed. So I would reject a CL to change all the calls.

[AlexsanderHamir]

Understood, thanks for the clarification and context.

[gopherbot]

Change https://go.dev/cl/708836 mentions this issue: fmt: reduce Errorf("x") allocations to match errors.New("x")