-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Closed
Labels
FixPendingIssues that have a fix which has not yet been reviewed or submitted.Issues that have a fix which has not yet been reviewed or submitted.
Milestone
Description
#!watchflakes
default <- pkg == "cmd/internal/moddeps" && test == "TestAllDependencies/std(thorough)"
Issue created automatically to collect these failures.
Example (log):
=== RUN TestAllDependencies/std(thorough)
moddeps_test.go:177: module std in directory /Users/swarming/.swarming/w/ir/x/w/goroot/src
moddeps_test.go:222: Module std in /Users/swarming/.swarming/w/ir/x/w/goroot/src is not tidy (-want +got):
diff --recursive --unified /Users/swarming/.swarming/w/ir/x/t/TestAllDependencies4229374583/002/src/internal/syscall/windows/zsyscall_windows.go /Users/swarming/.swarming/w/ir/x/w/goroot/src/internal/syscall/windows/zsyscall_windows.go
--- /Users/swarming/.swarming/w/ir/x/t/TestAllDependencies4229374583/002/src/internal/syscall/windows/zsyscall_windows.go 2025-09-26 10:38:13
+++ /Users/swarming/.swarming/w/ir/x/w/goroot/src/internal/syscall/windows/zsyscall_windows.go 2025-09-26 10:03:26
@@ -328,7 +328,7 @@
}
func GetFileSizeEx(handle syscall.Handle, size *int64) (err error) {
- r1, _, e1 := syscall.SyscallN(procGetFileSizeEx.Addr(), uintptr(handle), uintptr(unsafe.Pointer(size)))
+ r1, _, e1 := syscall.Syscall(procGetFileSizeEx.Addr(), 2, uintptr(handle), uintptr(unsafe.Pointer(size)), 0)
if r1 == 0 {
err = errnoErr(e1)
}
To fix it, run:
$ cd /Users/swarming/.swarming/w/ir/x/w/goroot/src
$ go mod tidy # to remove extraneous dependencies
$ go mod vendor # to vendor dependencies
$ go generate -run=bundle std # to regenerate bundled packages
$ go generate syscall internal/syscall/... # to regenerate syscall packages
(If module std is definitely tidy, this could mean
there's a problem in the go or bundle command.)
--- FAIL: TestAllDependencies/std(thorough) (73.80s)
Metadata
Metadata
Assignees
Labels
FixPendingIssues that have a fix which has not yet been reviewed or submitted.Issues that have a fix which has not yet been reviewed or submitted.
Type
Projects
Status
Done