ssh: Additional AuthMethods are ignored

[gopherbot]

by gereon.frey@dynport.de:

What does 'go version' print?
go version devel +1a32fe60e079 Thu Feb 13 03:09:03 2014 -0500 linux/amd64

What steps reproduce the problem?
If possible, include a link to a program on play.golang.org.

1. Updated go.crypto/ssh (aka gosshnew)
2. Had a ClientConfig with multiple supported AuthMethods ("password" and
"publickey") like in http://play.golang.org/p/BHActTctt9

What happened?
ssh: unable to authenticate, attempted methods [none publickey], no supported methods
remain

What should have happened instead?
It should have tried "password", too.

Please provide any additional information below.
Problem is related to the nested for loops in connection.clientAuthenticate used to
determine the common client requested and server supported methods. The break statement
just stops the inner loop, so that only the last common method is used.

Attached patch fixes issue.

Attachments:

1. crypto.patch (603 bytes)

[davecheney]

Comment 1:

What authentication methods does your server support, try ssh -vv and look for lines
mentioning the authentication methods supported by the server -- the ssh client can only
try the intersection of methods supported by both parties.

Status changed to WaitingForReply.

[gopherbot]

Comment 2 by gereon.frey@dynport.de:

Authentications that can continue: publickey,password

[agl]

Comment 3:

https://golang.org/cl/94350043/

Labels changed: added repo-crypto.

Owner changed to @agl.

Status changed to Accepted.

[gopherbot]

Comment 4:

CL https://golang.org/cl/94350043 mentions this issue.

[agl]

Comment 5:

This issue was closed by revision golang/crypto@c34e38a.

Status changed to Fixed.