New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/gc: build fails with new on-stack select and '-N' build gcflag #8396

Closed
bpowers opened this Issue Jul 21, 2014 · 6 comments

Comments

Projects
None yet
5 participants
@bpowers
Contributor

bpowers commented Jul 21, 2014

After e1d0077340e8 (cmd/gc: allocate select descriptor on stack), the small program
http://play.golang.org/p/edu4EdUYUU from #8336 hits an internal compiler error:

# issue
./main.go:13: internal compiler error: without escape analysis, only PAUTO's should have
esc: autotmp_0001
@bpowers

This comment has been minimized.

Show comment
Hide comment
@bpowers

bpowers Jul 21, 2014

Contributor

Comment 1:

CL to address this is https://golang.org/cl/112520043
Contributor

bpowers commented Jul 21, 2014

Comment 1:

CL to address this is https://golang.org/cl/112520043
@dvyukov

This comment has been minimized.

Show comment
Hide comment
@dvyukov

dvyukov Jul 21, 2014

Member

Comment 2:

Are you going to mail the CL?
Member

dvyukov commented Jul 21, 2014

Comment 2:

Are you going to mail the CL?
@bpowers

This comment has been minimized.

Show comment
Hide comment
@bpowers

bpowers Jul 21, 2014

Contributor

Comment 3:

yes, my mistake.  It is now mailed.
Contributor

bpowers commented Jul 21, 2014

Comment 3:

yes, my mistake.  It is now mailed.
@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Jul 21, 2014

Comment 4:

CL https://golang.org/cl/112520043 mentions this issue.

Comment 4:

CL https://golang.org/cl/112520043 mentions this issue.
@ianlancetaylor

This comment has been minimized.

Show comment
Hide comment
@ianlancetaylor

ianlancetaylor Jul 21, 2014

Contributor

Comment 5:

Labels changed: added repo-main, release-go1.4.

Contributor

ianlancetaylor commented Jul 21, 2014

Comment 5:

Labels changed: added repo-main, release-go1.4.

@dvyukov

This comment has been minimized.

Show comment
Hide comment
@dvyukov

dvyukov Jul 25, 2014

Member

Comment 6:

This issue was closed by revision 0f2cde8.

Status changed to Fixed.

Member

dvyukov commented Jul 25, 2014

Comment 6:

This issue was closed by revision 0f2cde8.

Status changed to Fixed.

@bpowers bpowers added fixed labels Jul 25, 2014

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015

@rsc rsc removed the release-go1.4 label Apr 14, 2015

@golang golang locked and limited conversation to collaborators Jun 25, 2016

wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018

cmd/gc: don't mark select descriptor as EscNone
selv is created with temp() which calls tempname, which marks
the new n with EscNever, so there is no need to explicitly set
EscNone on the select descriptor.

Fixes #8396.

LGTM=dvyukov
R=golang-codereviews, dave, dvyukov
CC=golang-codereviews
https://golang.org/cl/112520043

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018

cmd/gc: don't mark select descriptor as EscNone
selv is created with temp() which calls tempname, which marks
the new n with EscNever, so there is no need to explicitly set
EscNone on the select descriptor.

Fixes #8396.

LGTM=dvyukov
R=golang-codereviews, dave, dvyukov
CC=golang-codereviews
https://golang.org/cl/112520043

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.