net: wrong sample code in package document #8607
Description
by xiezhenye:
sample of net.Conn.Accept：
ln, err := net.Listen("tcp", ":8080")
if err != nil {
// handle error
}
for {
conn, err := ln.Accept()
if err != nil {
// handle error
continue
}
go handleConnection(conn)
}
When err that Accept returns is not nil, it must not continue the loop.
recoverable err like syscall.EAGAIN, syscall.ECONNABORTED has been handler in Accept,
and all the err that returned is not recoverable. continue the loop will cause dead loop.
the sample should be:
ln, err := net.Listen("tcp", ":8080")
if err != nil {
// handle error
}
for {
conn, err := ln.Accept()
if err != nil {
// handle error
break
}
go handleConnection(conn)
}