builder: add gcflags="-N -l" variant

[josharian]

These gcflags are commonly used with debuggers. Such a builder variant would have caught
issue #8585.

[davecheney]

Comment 1:

Yes. I think this is really important. Thanks for raising this issue.

[bradfitz]

Comment 2:

Labels changed: added builder.

[bradfitz]

Comment 3:

Is this just GO_GCFLAGS="-N -l" ?
Is that respected everywhere?

[josharian]

Comment 4:

>Is this just GO_GCFLAGS="-N -l" ? Is that respected everywhere?
Not 100% sure. But without CL 132970043 all.bash build fails while compiling the runtime
(as expected--no escape analysis), and with CL 132970043 all.bash succeeds. So it seems
like a good place to start.

[gopherbot]

Comment 5:

CL https://golang.org/cl/149000043 mentions this issue.

[bradfitz]

Comment 6:

This issue was updated by revision fb4e185.

LGTM=rsc, josharian
R=rsc, josharian
CC=golang-codereviews
https://golang.org/cl/149000043

[bradfitz]

Comment 7:

At tip right now: (be7b6351d83d)
ba12:src bradfitz$ GO_GCFLAGS="-N -l" ./all.bash
# Building C bootstrap tool.
cmd/dist
# Building compilers and Go bootstrap tool for host, darwin/amd64.
lib9
libbio
liblink
misc/pprof
cmd/cc
cmd/gc
cmd/6l
cmd/6a
cmd/6c
cmd/6g
runtime
errors
sync/atomic
sync
io
unicode
unicode/utf8
unicode/utf16
bytes
math
strings
strconv
bufio
sort
container/heap
encoding/base64
syscall
time
os
reflect
fmt
encoding
encoding/json
flag
path/filepath
path
io/ioutil
log
regexp/syntax
regexp
go/token
go/scanner
go/ast
go/parser
os/exec
os/signal
net/url
text/template/parse
text/template
go/doc
go/build
cmd/go
# Building packages and commands for darwin/amd64.
runtime
errors
sync/atomic
unicode
unicode/utf8
math
sync
sort
io
syscall
hash
container/heap
encoding
unicode/utf16
bytes
strings
bufio
text/tabwriter
path
time
hash/crc32
container/list
crypto/subtle
compress/bzip2
crypto/cipher
crypto/hmac
hash/adler32
container/ring
hash/crc64
hash/fnv
html
image/color
strconv
math/rand
os
image/color/palette
math/cmplx
reflect
crypto
path/filepath
crypto/md5
encoding/base64
regexp/syntax
net/url
io/ioutil
os/exec
crypto/aes
crypto/rc4
crypto/sha1
crypto/sha256
crypto/sha512
regexp
encoding/pem
os/signal
encoding/ascii85
encoding/binary
fmt
encoding/base32
image
crypto/des
index/suffixarray
runtime/race
image/draw
image/jpeg
debug/dwarf
debug/goobj
debug/gosym
debug/plan9obj
flag
log
go/token
encoding/json
debug/elf
debug/macho
debug/pe
go/scanner
encoding/xml
go/ast
cmd/internal/objfile
text/template/parse
cmd/addr2line
compress/flate
text/template
go/parser
go/printer
go/doc
compress/gzip
math/big
encoding/hex
mime
cmd/cgo
go/format
go/build
cmd/fix
crypto/elliptic
encoding/asn1
crypto/rand
crypto/rsa
crypto/ecdsa
crypto/dsa
crypto/x509/pkix
net/http/internal
runtime/pprof
cmd/link
cmd/gofmt
cmd/nm
cmd/objdump
runtime/cgo
# runtime/cgo
runtime: unexpected return pc for runtime.goexit called from 0x0
fatal error: unknown caller pc
runtime stack:
runtime.gothrow(0x2d3290, 0x11)
    /Users/bradfitz/go/src/runtime/panic.go:477 +0xcf
runtime.gentraceback(0x71170, 0x20843c200, 0x0, 0x208422120, 0x0, 0x0, 0x7fffffff,
0x7fff5fbff7c0, 0x7fff5fbff7d0, 0x3e2200, ...)
    /Users/bradfitz/go/src/runtime/traceback.go:192 +0x107c
copystack(0x208422120, 0x1000)
    /Users/bradfitz/go/src/runtime/stack.c:621 +0x173
runtime.newstack()
    /Users/bradfitz/go/src/runtime/stack.c:774 +0x552
runtime.morestack()
    /Users/bradfitz/go/src/runtime/asm_amd64.s:324 +0x7e
goroutine 1 [stack growth, locked to thread]:
runtime.gogc(0x2200000000)
    /Users/bradfitz/go/src/runtime/malloc.go:413 fp=0x20843c208 sp=0x20843c200
runtime.mallocgc(0x10, 0x2637a0, 0x0, 0x0)
    /Users/bradfitz/go/src/runtime/malloc.go:341 +0x6b9 fp=0x20843c400 sp=0x20843c208
runtime.newobject(0x2637a0, 0x0)
    /Users/bradfitz/go/src/runtime/malloc.go:353 +0x85 fp=0x20843c440 sp=0x20843c400
runtime.convT2I(0x2637a0, 0x24e820, 0x3de6e8, 0x20845af68, 0x0, 0x0)
    /Users/bradfitz/go/src/runtime/iface.go:163 +0x177 fp=0x20843c4a8 sp=0x20843c440
runtime.init()
    /Users/bradfitz/go/src/runtime/panic.go:9 +0x3b4 fp=0x20843c780 sp=0x20843c4a8
runtime.main()
    /Users/bradfitz/go/src/runtime/proc.go:46 +0xcb fp=0x20843c7e0 sp=0x20843c780
runtime.goexit()
    /Users/bradfitz/go/src/runtime/proc.c:1662 fp=0x20843c7e8 sp=0x20843c7e0
cmd/pack
cmd/yacc
archive/tar
archive/zip
compress/lzw
compress/zlib

[josharian]

Comment 8:

Fixed by CL 148060043.

Status changed to Fixed.