-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime,sync/atomic: unify API for runtime/internal/atomic and sync/atomic #8739
Comments
There's no evidence in profiles that this is important for Go 1.5. |
\cc @randall77, I vaguely remember you mentioning that we already intrinsify atomic.X functions. Is this done? |
They are for 1.8. We intrinsify both sync/atomic and runtime/internal/atomic for a bunch of architectures. |
I'm planning to implement the atomics as intrinsics on ppc64x. Should I refer to this issue in my CL or open a new one. |
You can reference this issue. |
@randall77, I've had a change to intrinsify atomics for ppc64x that worked fine a few months ago. When I tried to rebase it, now it hangs during the build. I've tracked it down to commit 8a9dc05 to allow inlining of functions with intrinsics in them. If I remove the code from that commit, then my change to intrinsify atomics works again. |
@laboger Can you point me at your intrinsics CL? |
@randall77 I didn't create one yet since it didn't build. But I will do that now. |
CL https://golang.org/cl/36832 mentions this issue. |
CL #36832 |
Was this issue supposed to be closed with CL 36832? The CL is specific to PPC64x but it looks like this issue is not specific to any architecture. |
No, we should leave it open. I think the remaining task is unifying the apis for sync/atomic and runtime/internal/atomic. |
The text was updated successfully, but these errors were encountered: