Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: implement external linking support for ppc64/linux #8912

Open
ianlancetaylor opened this issue Oct 9, 2014 · 3 comments
Assignees
Milestone

Comments

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 9, 2014

We need to fix the 9l linker to provide external linking support, so that
-linkmode=external works on power64.

This code is currently on the dev.power64 branch and should come into tip after the 1.4
release is out.  This means writing elfreloc1, elfsetupplt, adddynsym, adddynrela, etc.,
in cmd/9l/asm.c and doing whatever else is necessary so that (cd misc/cgo/test
&& go test -linkmode=external) passes for both big- and little- endian power64.
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor Author

@ianlancetaylor ianlancetaylor commented Oct 9, 2014

Comment 2:

Doing "whatever else is necessary" to make misc/cgo/test pass will include writing
asm_power64be.s, asm_power64le.s, and gcc_linux_power64{be,ls}.s in the runtime/cgo
package.
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 15, 2014

@minux

This comment has been minimized.

Copy link
Member

@minux minux commented Nov 1, 2014

Comment 6:

Issue #9038 has been merged into this issue.

@aclements aclements self-assigned this Dec 22, 2014
aclements added a commit that referenced this issue Jan 16, 2015
This test requires external linking, but we don't yet implement
external linking on ppc64 (tracked in issue #8912).  Disable the test
on ppc64 until external linking is implemented.

This makes all.bash pass on ppc64le.

Change-Id: I741498d4d9321607e7a65792a33faf8187bd18e4
Reviewed-on: https://go-review.googlesource.com/2908
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@rsc rsc removed the arch-ppc64 label Apr 10, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc removed release-none labels Apr 10, 2015
@minux minux assigned minux and unassigned aclements May 4, 2015
@rsc rsc changed the title cmd/9l: implement external linking support for Power64 Linux cmd/link: implement external linking support for ppc64/linux Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.