builder: fatal: destination path 'go.tools.TMP' already exists and is not an empty directory.

[bradfitz]

The Windows builder has been seen failing with:

fatal: destination path 'go.tools.TMP' already exists and is not an empty directory.

in e.g. http://build.golang.org/log/56ef938f142bad19e56ef8c78620877baa3baf90

Should fix.

[alexbrainman]

I suspect the problem is that go.tools.TMP is created relative to the current builder directory. If builder executes 2 different builds simultaneously (and windows builder does run 386 and amd64 together), then it is possible both builds are trying to clone https://go.googlesource.com/tools to the same directory ./go.tools.TMP.

It is easy enough to make unique directory in /tmp to overcome that, but other code (that moves go.tools.TMP into its final destination is suspect too). Maybe it does not matter.

I can send CL to change go.tools.TMP location. Cannot think of anything else to do. What do you think, Brad?

Alex

[adg]

On 22 December 2014 at 14:40, alexbrainman notifications@github.com wrote:

I can send CL to change go.tools.TMP location. Cannot think of anything
else to do. What do you think, Brad?

What is creating the go.tools.TMP directory? git?

[alexbrainman]

My apology. go.tools.TMP is created relative to C:\DOCUME1\brainman\LOCALS1\Temp\gopath-api-SGE_brainman-devel\875ff2496f865e\src\code.google.com\p. But my suggestion still stands. We should not make 2 simultaneous git clone repo into the same directory.

Alex

[minux]

It's cmd/api/run.go that choose to first clone it there.

It probably doesn't consider the case where the builder
could be building two copies of Go of the same revision
at the same time.

[alexbrainman]

I will let Brad fix this.

Alex

[bradfitz]

Mailed https://go-review.googlesource.com/1980

[alexbrainman]

Renaming is still a race. From http://build.golang.org/log/00e371a6188c662b47dd1f0e7a70eb85b0d9ab01

##### ..\test

rename C:\Users\WINGOP~1\AppData\Local\Temp\2\gopath-api-WINDOWS-MANUAL_wingopher-b68c0aec20776e85b8d71fc32ab788cec8979e4b\875ff2496f865e\src\code.google.com\p\go.tools.TMP.windows.amd64 C:\Users\WINGOP~1\AppData\Local\Temp\2\gopath-api-WINDOWS-MANUAL_wingopher-b68c0aec20776e85b8d71fc32ab788cec8979e4b\875ff2496f865e\src\code.google.com\p\go.tools: Cannot create a file when that file already exists.
exit status 1
Build complete, duration 4m43.7934276s. Result: error: exit status 1

[bradfitz]

On Windows, will that error be true if passed to os.IsExist?

[alexbrainman]

I will try.

[alexbrainman]

Yes, os.IsExist(err) is true after os.Rename fails.

Alex