Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestResponseWriterWriteStringAllocs fails on windows-amd64 #9575

Closed
alexbrainman opened this issue Jan 13, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@alexbrainman
Copy link
Member

commented Jan 13, 2015

windows-amd64 build http://build.golang.org/log/f117061c3ee9fa9bb29820834431b964d9137d71 fails with

--- FAIL: TestResponseWriterWriteStringAllocs (0.01s)
serve_test.go:2398: WriteString allocs of 21 >= Write allocs of 21
FAIL
FAIL net/http 8.384s

@minux

This comment has been minimized.

Copy link
Member

commented Jan 13, 2015

Not a windows specific problem.

On linux/amd64:
$ go test net/http -v -run=TestResponseWriterWriteStringAllocs
=== RUN TestResponseWriterWriteStringAllocs
--- FAIL: TestResponseWriterWriteStringAllocs (0.07s)
serve_test.go:2398: WriteString allocs of 39 >= Write allocs of 22
FAIL
exit status 1
FAIL net/http 0.070s

I think a lot of allocation tests are broken after the interface pointer
change.
(Esp. those not run during -short)

@alexbrainman

This comment has been minimized.

Copy link
Member Author

commented Jan 13, 2015

It seems this happened before and has been corrected by increasing number of testing.AllocsPerRun:

commit 542415c
Author: Brad Fitzpatrick bradfitz@golang.org
Date: Tue Mar 4 09:59:07 2014 -0800

net/http: deflake another alloc test

I have one machine where this 25 test run is flaky
and fails ("21 >= 21"), but 50 works everywhere.

LGTM=josharian
R=josharian
CC=golang-codereviews
https://golang.org/cl/67870053

It appears my problem goes away if I increase that number again to 100. Should I send a CL?

Alex

@minux

This comment has been minimized.

Copy link
Member

commented Jan 13, 2015

we need to ask @bradfitz to decide.

@bradfitz bradfitz self-assigned this Jan 13, 2015

@bradfitz

This comment has been minimized.

Copy link
Member

commented Jan 13, 2015

@bradfitz bradfitz closed this in 3ab4b68 Jan 13, 2015

@golang golang locked and limited conversation to collaborators Jun 25, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.