Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: Expose http server for ACME letsencrypt #11649

Closed

Conversation

Projects
None yet
3 participants
@solderjs
Copy link

commented Jul 10, 2015

https://LetsEncrypt.org's release is just around the corner, but it's currently not possible to dynamically retrieve and renew certificates in go with an active http server.

To do so requires fixing a tiny regression introduced sometime between the move from httputils and now. See https://golang.org/pkg/net/http/httputil/#ServerConn.

We need to re-expose http.NewConn and http.conn.Serve.

I've got a working demo of dynamically loading certificates with this change here:
https://gist.github.com/coolaj86/16ed8fd810e19dec71be

I've already signed the CLA and with a little coaching I'm sure I could turn my example into an appropriate test case.

@mikioh

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2015

Please take a look at #9220.

@mikioh mikioh closed this Jul 10, 2015

@mikioh mikioh changed the title Expose http server for ACME letsencrypt net/http: Expose http server for ACME letsencrypt Jul 10, 2015

@solderjs

This comment has been minimized.

Copy link
Author

commented Jul 10, 2015

Do I really have to go through a 2 hour process to make a 4-line fix? I mean, I need the regression fixed, but I already spent so many hours figuring it out and now more hours figuring out some process that I'm probably only going to use once or twice.... sadness

</3

The ache of my bleeding heart...

Oh the bemoanments.... agaoeurcgkhnetsus.O͇̹̺ͅƝ̴ȳ̳ TH̘Ë͖́̉ ͠P̯͍̭O̚​N̐Y̡ H̸̡̪̯ͨ͊̽̅̾̎Ȩ̬̩̾͛ͪ̈́̀́͘ ̶̧̨̱̹̭̯ͧ̾ͬC̷̙̲̝͖ͭ̏ͥͮ͟Oͮ͏̮̪̝͍M̲̖͊̒ͪͩͬ̚̚͜Ȇ̴̟̟͙̞ͩ͌͝

@golang golang locked and limited conversation to collaborators Jul 11, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.