Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: rename the TestGcHashmapIndirection to TestGcMapIndirection #24074

Closed

Conversation

@mingrammer
Copy link
Contributor

@mingrammer mingrammer commented Feb 23, 2018

The hashmap was renamed with map few days ago.

But there is still 'Hashmap' word on gc_test.go, so I renamed this with just 'Map'

Related commit: f4bb25c

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 23, 2018

This PR (HEAD: 0beb5fc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/96656 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 23, 2018

Message from Ian Lance Taylor:

Patch Set 1:

Is this the same as https://golang.org/cl/96675? I made a comment over there.


Please don’t reply on this GitHub thread. Visit golang.org/cl/96656.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 23, 2018

Message from mingrammer:

Patch Set 1:

Patch Set 1:

Is this the same as https://golang.org/cl/96675? I made a comment over there.

Yes, they are same. I'll fix the commit message. Thanks


Please don’t reply on this GitHub thread. Visit golang.org/cl/96656.
After addressing review feedback, remember to publish your drafts!

There is still 'Hashmap' word on gc_test.go, so I renamed this with just 'Map'

Related commit: https://golang.org/cl/90336

Change-Id: I5b0e5c2229d1c30937c7216247f4533effb81ce7
@mingrammer mingrammer force-pushed the rename-the-hashmap-to-map branch from 0beb5fc to 34f6304 Feb 23, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 23, 2018

This PR (HEAD: 34f6304) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/96656 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 23, 2018

Message from Gerrit Bot:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/96656.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 23, 2018

This PR is being closed because golang.org/cl/96656 has been abandoned.

@gopherbot gopherbot closed this Feb 23, 2018
@mingrammer mingrammer deleted the rename-the-hashmap-to-map branch Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants