mime/multipart: test for presence of filename instead of content-type #24104

hcliff · 2018-02-24T18:58:10Z

Preserving the intended fix in https://go.googlesource.com/go/+/81ec7256072ed5e20b8827c583193258769aebc0

…on test

googlebot · 2018-02-24T18:58:15Z

Thanks for your pull request. t looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

hcliff · 2018-02-24T18:59:28Z

I signed it!

googlebot · 2018-02-24T18:59:31Z

CLAs look good, thanks!

gopherbot · 2018-02-24T19:02:30Z

This PR (HEAD: 14973d7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/96975 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-02-24T19:03:00Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

andybons · 2018-02-25T01:27:19Z

Apologies for the spam.

gopherbot · 2018-02-26T18:23:47Z

Message from Gerrit Bot:

Uploaded patch set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-02-26T18:45:17Z

Message from Brad Fitzpatrick:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-02-26T18:45:25Z

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=3105d8b9

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-02-26T18:55:44Z

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-09T20:40:14Z

Message from henry clifford:

Patch Set 2:

anything I can do to help? thanks!

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-09T20:47:54Z

Message from Andrew Bonventre:

Patch Set 2:

Patch Set 2:

anything I can do to help? thanks!

You still have to resolve the comment Brad had about the commit message.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-09T21:08:19Z

Message from henry clifford:

Patch Set 2:

Patch Set 2:

Patch Set 2:

anything I can do to help? thanks!

You still have to resolve the comment Brad had about the commit message.

got it, thanks. need to adjust to gerrit.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-09T21:15:28Z

Message from Gerrit Bot:

Uploaded patch set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-09T21:16:22Z

Message from henry clifford:

Patch Set 3:

Patch Set 2: Run-TryBot+1

(1 comment)

I've updated the PR description, is this sufficient or would you like me to fixup the actual commit message.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-09T22:23:18Z

Message from Andrew Bonventre:

Patch Set 3:

Patch Set 3:

Patch Set 2: Run-TryBot+1

(1 comment)

I've updated the PR description, is this sufficient or would you like me to fixup the actual commit message.

I would replace the github link with the canonical one: https://go.googlesource.com/go/+/81ec7256072ed5e20b8827c583193258769aebc0

GitHub is just a mirror. Once that's done, LGTM

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-09T22:29:13Z

Message from Gerrit Bot:

Uploaded patch set 4: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-09T22:29:59Z

Message from henry clifford:

Patch Set 4:

Patch Set 3:

Patch Set 3:

Patch Set 2: Run-TryBot+1

(1 comment)

I've updated the PR description, is this sufficient or would you like me to fixup the actual commit message.

I would replace the github link with the canonical one: https://go.googlesource.com/go/+/81ec7256072ed5e20b8827c583193258769aebc0

GitHub is just a mirror. Once that's done, LGTM

done!

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-09T22:32:02Z

Message from Andrew Bonventre:

Patch Set 4: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-09T22:32:12Z

Message from Andrew Bonventre:

Patch Set 4: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-09T22:32:21Z

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=dd917107

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-09T22:41:23Z

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96975.
After addressing review feedback, remember to publish your drafts!

Fixes #24041 Preserving the intended fix in https://go.googlesource.com/go/+/81ec7256072ed5e20b8827c583193258769aebc0 Change-Id: I600d3d7edc74ca072a066739e2ef3235877d808f GitHub-Last-Rev: 14973d7 GitHub-Pull-Request: #24104 Reviewed-on: https://go-review.googlesource.com/96975 Reviewed-by: Andrew Bonventre <andybons@golang.org> Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

gopherbot · 2018-03-10T00:38:44Z

This PR is being closed because golang.org/cl/96975 has been merged.

test for presence of filename instead of content-type, add a regressi…

14973d7

…on test

googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Feb 24, 2018

googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Feb 24, 2018

mime/multipart: test for presence of filename instead of content-type #24104

mime/multipart: test for presence of filename instead of content-type #24104

Uh oh!

Conversation

hcliff commented Feb 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Feb 24, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

hcliff commented Feb 24, 2018

Uh oh!

googlebot commented Feb 24, 2018

Uh oh!

gopherbot commented Feb 24, 2018

Uh oh!

gopherbot commented Feb 24, 2018

Uh oh!

andybons commented Feb 25, 2018

Uh oh!

gopherbot commented Feb 26, 2018

Uh oh!

gopherbot commented Feb 26, 2018

Uh oh!

gopherbot commented Feb 26, 2018

Uh oh!

gopherbot commented Feb 26, 2018

Uh oh!

gopherbot commented Mar 9, 2018

Uh oh!

gopherbot commented Mar 9, 2018

Uh oh!

gopherbot commented Mar 9, 2018

Uh oh!

gopherbot commented Mar 9, 2018

Uh oh!

gopherbot commented Mar 9, 2018

Uh oh!

gopherbot commented Mar 9, 2018

Uh oh!

gopherbot commented Mar 9, 2018

Uh oh!

gopherbot commented Mar 9, 2018

Uh oh!

gopherbot commented Mar 9, 2018

Uh oh!

gopherbot commented Mar 9, 2018

Uh oh!

gopherbot commented Mar 9, 2018

Uh oh!

gopherbot commented Mar 9, 2018

Uh oh!

gopherbot commented Mar 10, 2018

Uh oh!

Uh oh!

hcliff commented Feb 24, 2018 •

edited

Loading