runtime: fix panic if newstack at runtime.acquireLockRank #40844

chainhelen · 2020-08-17T15:40:51Z

Process may crash becaues acquireLockRank and releaseLockRank may
be called in nosplit context. With optimizations and inlining
disabled, these functions won't get inlined or have their morestack
calls eliminated.
Nosplit is not strictly required for lockWithRank, unlockWithRank
and lockWithRankMayAcquire, just keep consistency with lockrank_on.go
here.

Fixes #40843

gopherbot · 2020-08-17T15:57:28Z

This PR (HEAD: 3cad25e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/248878 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-08-17T19:47:58Z

Message from Michael Pratt:

Patch Set 1: Code-Review-1

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-17T19:49:33Z

Message from Michael Pratt:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-17T19:51:18Z

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=ecebfc00

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-17T20:18:17Z

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-18T06:15:43Z

This PR (HEAD: e37bf92) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/248878 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-08-18T06:39:15Z

This PR (HEAD: 19948db) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/248878 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-08-18T09:41:36Z

Message from chainhelen:

Patch Set 4:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-18T14:52:16Z

Message from Michael Pratt:

Patch Set 4: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-18T14:52:17Z

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=afcf1f79

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-18T15:03:37Z

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-20T18:22:54Z

Message from Austin Clements:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-21T07:48:34Z

This PR (HEAD: 9f29912) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/248878 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-08-21T07:59:14Z

Message from chainhelen:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-21T14:10:22Z

Message from Austin Clements:

Patch Set 5:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

Process may crash becaues acquireLockRank and releaseLockRank may be called in nosplit context. With optimizations and inlining disabled, these functions won't get inlined or have their morestack calls eliminated. Nosplit is not strictly required for lockWithRank, unlockWithRank and lockWithRankMayAcquire, just keep consistency with lockrank_on.go here. Fixes golang#40843

gopherbot · 2020-08-21T16:44:59Z

This PR (HEAD: 38fd3cc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/248878 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-08-21T16:49:48Z

Message from chainhelen:

Patch Set 6:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-24T16:05:04Z

Message from Dan Scales:

Patch Set 6: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-24T16:56:18Z

Message from Emmanuel Odeke:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-24T16:56:19Z

Message from Gobot Gobot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=10846ade

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-24T17:11:15Z

Message from Gobot Gobot:

Patch Set 6: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-08-30T15:01:26Z

Message from chainhelen:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-09-01T23:09:54Z

Message from Dmitri Shuralyov:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/248878.
After addressing review feedback, remember to publish your drafts!

Process may crash becaues acquireLockRank and releaseLockRank may be called in nosplit context. With optimizations and inlining disabled, these functions won't get inlined or have their morestack calls eliminated. Nosplit is not strictly required for lockWithRank, unlockWithRank and lockWithRankMayAcquire, just keep consistency with lockrank_on.go here. Fixes #40843 Change-Id: I5824119f98a1da66d767cdb9a60dffe768f13c81 GitHub-Last-Rev: 38fd3cc GitHub-Pull-Request: #40844 Reviewed-on: https://go-review.googlesource.com/c/go/+/248878 Reviewed-by: Dan Scales <danscales@google.com> Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

gopherbot · 2020-09-01T23:21:36Z

This PR is being closed because golang.org/cl/248878 has been merged.

…uireLockRank Process may crash becaues acquireLockRank and releaseLockRank may be called in nosplit context. With optimizations and inlining disabled, these functions won't get inlined or have their morestack calls eliminated. Nosplit is not strictly required for lockWithRank, unlockWithRank and lockWithRankMayAcquire, just keep consistency with lockrank_on.go here. Updates #40843. Fixes #40845. Change-Id: I5824119f98a1da66d767cdb9a60dffe768f13c81 GitHub-Last-Rev: 38fd3cc GitHub-Pull-Request: #40844 Reviewed-on: https://go-review.googlesource.com/c/go/+/248878 Reviewed-by: Dan Scales <danscales@google.com> Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> (cherry picked from commit b246c0e) Reviewed-on: https://go-review.googlesource.com/c/go/+/252339 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>

…uireLockRank Process may crash becaues acquireLockRank and releaseLockRank may be called in nosplit context. With optimizations and inlining disabled, these functions won't get inlined or have their morestack calls eliminated. Nosplit is not strictly required for lockWithRank, unlockWithRank and lockWithRankMayAcquire, just keep consistency with lockrank_on.go here. Updates golang#40843. Fixes golang#40845. Change-Id: I5824119f98a1da66d767cdb9a60dffe768f13c81 GitHub-Last-Rev: 38fd3cc GitHub-Pull-Request: golang#40844 Reviewed-on: https://go-review.googlesource.com/c/go/+/248878 Reviewed-by: Dan Scales <danscales@google.com> Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> (cherry picked from commit b246c0e) Reviewed-on: https://go-review.googlesource.com/c/go/+/252339 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>

googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Aug 17, 2020

chainhelen mentioned this pull request Aug 17, 2020

"stack split at bad time" error running tests on linux/i386 with Go1.15 go-delve/delve#2134

Closed

chainhelen mentioned this pull request Aug 17, 2020

runtime: Panic if newstack at runtime.acquireLockRank #40843

Closed

chainhelen force-pushed the acquireLockRank_panic branch from 3cad25e to e37bf92 Compare August 18, 2020 06:14

chainhelen force-pushed the acquireLockRank_panic branch from e37bf92 to 19948db Compare August 18, 2020 06:37

chainhelen changed the title ~~runtime: Fix panic if newstack at runtime.acquireLockRank~~ runtime: fix panic if newstack at runtime.acquireLockRank Aug 18, 2020

chainhelen force-pushed the acquireLockRank_panic branch from 19948db to 9f29912 Compare August 21, 2020 07:47

chainhelen force-pushed the acquireLockRank_panic branch from 9f29912 to 38fd3cc Compare August 21, 2020 16:43

gopherbot closed this Sep 1, 2020

runtime: fix panic if newstack at runtime.acquireLockRank #40844

runtime: fix panic if newstack at runtime.acquireLockRank #40844

Uh oh!

Conversation

chainhelen commented Aug 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Aug 17, 2020

Uh oh!

gopherbot commented Aug 17, 2020

Uh oh!

gopherbot commented Aug 17, 2020

Uh oh!

gopherbot commented Aug 17, 2020

Uh oh!

gopherbot commented Aug 17, 2020

Uh oh!

gopherbot commented Aug 18, 2020

Uh oh!

gopherbot commented Aug 18, 2020

Uh oh!

gopherbot commented Aug 18, 2020

Uh oh!

gopherbot commented Aug 18, 2020

Uh oh!

gopherbot commented Aug 18, 2020

Uh oh!

gopherbot commented Aug 18, 2020

Uh oh!

gopherbot commented Aug 20, 2020

Uh oh!

gopherbot commented Aug 21, 2020

Uh oh!

gopherbot commented Aug 21, 2020

Uh oh!

gopherbot commented Aug 21, 2020

Uh oh!

gopherbot commented Aug 21, 2020

Uh oh!

gopherbot commented Aug 21, 2020

Uh oh!

gopherbot commented Aug 24, 2020

Uh oh!

gopherbot commented Aug 24, 2020

Uh oh!

gopherbot commented Aug 24, 2020

Uh oh!

gopherbot commented Aug 24, 2020

Uh oh!

gopherbot commented Aug 30, 2020

Uh oh!

gopherbot commented Sep 1, 2020

Uh oh!

gopherbot commented Sep 1, 2020

Uh oh!

Uh oh!

chainhelen commented Aug 17, 2020 •

edited

Loading