Skip to content

go/types: use flag variable goversion #46585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

go/types: use flag variable goversion #46585

wants to merge 4 commits into from

Conversation

avelino
Copy link
Contributor

@avelino avelino commented Jun 5, 2021

  • grouping declaration of variables on check_test.go
  • change function name from checkFiles to testFiles

Signed-off-by: Avelino avelinorun@gmail.com

@avelino
go/types: use flag variable goversion
d5fb854 
- grouping declaration of variables on check_test.go
- change function name from `checkFiles` to `testFiles`

Signed-off-by: Avelino <avelinorun@gmail.com>
@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jun 5, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: c39a61b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/325449 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@avelino
fixed indentation
6cc1596 
Signed-off-by: Avelino <avelinorun@gmail.com>
@gopherbot
Copy link
Contributor

This PR (HEAD: 6cc1596) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/325449 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@avelino
recovery call func testDir
76de9fb 
Signed-off-by: Avelino <avelinorun@gmail.com>
@gopherbot
Copy link
Contributor

This PR (HEAD: 76de9fb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/325449 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Robert Griesemer:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/325449.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 3: Code-Review-2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/325449.
After addressing review feedback, remember to publish your drafts!

@avelino avelino closed this Jun 7, 2021
@avelino avelino deleted the avelino/go-types-use-flag-variable-goversion branch June 7, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avelino @gopherbot