Skip to content

cmd/{compile, link}: support mapping symbols for ARM64 #47786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

vpachkov
Copy link
Contributor

@vpachkov vpachkov commented Aug 18, 2021

ELF for the Arm® 64-bit Architecture (AArch64):
Mapping symbols chapter
[https://github.com/ARM-software/abi-aa/blob/2020q4/aaelf64/aaelf64.rst#mapping-symbols]
requires that the special symbols are inserted into object files:
$x - At the start of a region of code containing AArch64 instructions.
$d - At the start of a region of data.

This patch introduces special mapping symbols that identify inline
transitions between code and literal pool boundaries.

Resolves #47908

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Aug 18, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 5e7a7b8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/343150 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Than McIntosh:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cherry Mui:

Patch Set 1: Code-Review-2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Than McIntosh:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Than McIntosh:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@vpachkov vpachkov force-pushed the support-mapping-symbols-for-arm64 branch from 5e7a7b8 to 7cf8206 Compare September 13, 2021 17:48
@gopherbot
Copy link
Contributor

This PR (HEAD: 7cf8206) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/343150 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Vyacheslav Pachkov:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Vyacheslav Pachkov:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Than McIntosh:

Patch Set 3:

(11 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Than McIntosh:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: bb9e3af) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/343150 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@vpachkov vpachkov changed the title cmd: support mapping symbols for ARM64 cmd/{compile, link}: support mapping symbols for ARM64 Oct 7, 2021
@gopherbot
Copy link
Contributor

Message from Vyacheslav Pachkov:

Patch Set 5:

(11 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Vyacheslav Pachkov:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Than McIntosh:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: ce0c5b1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/343150 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Vyacheslav Pachkov:

Patch Set 6:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Than McIntosh:

Patch Set 6: Run-TryBot+1

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 6: TryBot-Result-1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 47288d3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/343150 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@vpachkov vpachkov force-pushed the support-mapping-symbols-for-arm64 branch from 47288d3 to 2cfb926 Compare October 12, 2021 09:56
@gopherbot
Copy link
Contributor

This PR (HEAD: 2cfb926) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/343150 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Vyacheslav Pachkov:

Patch Set 8:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Than McIntosh:

Patch Set 8: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 8:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 8: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Than McIntosh:

Patch Set 8:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cherry Mui:

Patch Set 8: Code-Review-2

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 7be6a97) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/343150 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@vpachkov vpachkov force-pushed the support-mapping-symbols-for-arm64 branch from 7be6a97 to 467ebb8 Compare October 22, 2021 08:35
@gopherbot
Copy link
Contributor

This PR (HEAD: 467ebb8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/343150 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@vpachkov vpachkov force-pushed the support-mapping-symbols-for-arm64 branch from 467ebb8 to f7d8d8f Compare October 22, 2021 08:38
@gopherbot
Copy link
Contributor

This PR (HEAD: f7d8d8f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/343150 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Vyacheslav Pachkov:

Patch Set 11:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/343150.
After addressing review feedback, remember to publish your drafts!

@seankhliao seankhliao closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd: support mapping symbols for ARM64
3 participants