Skip to content

net/url: add JoinPath, URL.JoinPath #50383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

net/url: add JoinPath, URL.JoinPath #50383

wants to merge 7 commits into from

Conversation

earthboundkid
Copy link
Contributor

Builds on CL 332209.

Fixes #47005

@gopherbot
Copy link
Contributor

This PR (HEAD: 41a5d34) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/374654 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 5a67f0e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/374654 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Russ Cox:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carl Johnson:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Russ Cox:

Patch Set 3: Patch Set 2 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Russ Cox:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Russ Cox:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 565ccd0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/374654 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 1910d66) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/374654 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Carl Johnson:

Patch Set 3:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Russ Cox:

Patch Set 5:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: c06c3ce) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/374654 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Carl Johnson:

Patch Set 5:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Russ Cox:

Patch Set 6: Run-TryBot+1 Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 6: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carl Johnson:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

Author 王泽龙 and others added 6 commits March 4, 2022 09:46
@gopherbot
Copy link
Contributor

This PR (HEAD: 51b7350) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/374654 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Russ Cox:

Patch Set 8: Patch Set 7 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Russ Cox:

Patch Set 8: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Russ Cox:

Patch Set 8: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 8: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 8: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 8: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/374654.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 10, 2022
@earthboundkid @gopherbot
net/url: add JoinPath, URL.JoinPath
604140d 
Builds on CL 332209.

Fixes #47005

Change-Id: I82708dede05d79a196ca63f5a4e7cb5ac9a041ea
GitHub-Last-Rev: 51b7350
GitHub-Pull-Request: #50383
Reviewed-on: https://go-review.googlesource.com/c/go/+/374654
Reviewed-by: Russ Cox <rsc@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/374654 has been merged.

@gopherbot gopherbot closed this Mar 10, 2022
@earthboundkid earthboundkid deleted the cj/url-join branch March 28, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net/url: add JoinPath, URL.JoinPath
2 participants
@earthboundkid @gopherbot