-
Notifications
You must be signed in to change notification settings - Fork 18.4k
encoding/gob: extend partially allocated string slices #59173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: f5f9835) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/478215 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/478215. |
Message from Ian Lance Taylor: Patch Set 1: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/478215. |
There is a bug in the current implementation where very large `[]string` will not be extended, causing an index out of bounds panic. Fixes golang#59172
This PR (HEAD: d1a9866) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/478215 to see it. Tip: You can toggle comments from me using the |
Message from Johan Abildskov: Patch Set 2: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/478215. |
Message from Ian Lance Taylor: Patch Set 2: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/478215. |
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/478215. |
Message from Gopher Robot: Patch Set 2: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/478215. |
Message from Ian Lance Taylor: Patch Set 2: Auto-Submit+1 Code-Review+2 Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/478215. |
Message from Rob Pike: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/478215. |
Fixes #59172 Change-Id: I54d5e724f10117a40ec5dd58c810f6bbb2475933 GitHub-Last-Rev: d1a9866 GitHub-Pull-Request: #59173 Reviewed-on: https://go-review.googlesource.com/c/go/+/478215 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Rob Pike <r@golang.org> Run-TryBot: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com>
This PR is being closed because golang.org/cl/478215 has been merged. |
Fixes #59172