Skip to content

cmd/cover: fix fail of go tool cover when file in report doesn't exists while using -func or -html flag #74929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

cmd/cover: fix fail of go tool cover when file in report doesn't exists while using -func or -html flag #74929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/cmd/cover/func.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ func funcOutput(profile, outputFile string) error {
}
funcs, err := findFuncs(file)
if err != nil {
if errors.Is(err, os.ErrNotExist) {
continue
}
return err
}
// Now match up functions and profile blocks.
Expand Down
4 changes: 4 additions & 0 deletions src/cmd/cover/html.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ package main
import (
"bufio"
"cmd/internal/browser"
"errors"
"fmt"
"html/template"
"io"
Expand Down Expand Up @@ -45,6 +46,9 @@ func htmlOutput(profile, outfile string) error {
}
src, err := os.ReadFile(file)
if err != nil {
if errors.Is(err, os.ErrNotExist) {
continue
}
return fmt.Errorf("can't read %q: %v", fn, err)
}
var buf strings.Builder
Expand Down