-
Notifications
You must be signed in to change notification settings - Fork 18.4k
runtime: use futexes with 64-bit time on Linux #75306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 3484e2b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/701615. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 1: Commit-Queue+1 (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-09-08T01:01:27Z","revision":"f2e24150d377c634503bc9f7e5f3157a01d7a57d"} Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
This PR (HEAD: 5962a6a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/701615. Important tips:
|
Message from Jorropo: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Daniel Maslowski: Patch Set 2: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
This PR (HEAD: 6b226b1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/701615. Important tips:
|
Message from Jorropo: Patch Set 4: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
This PR (HEAD: baa3513) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/701615. Important tips:
|
Message from Daniel Maslowski: Patch Set 5: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
This PR (HEAD: e6236ba) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/701615. Important tips:
|
Message from Jorropo: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
This PR (HEAD: 695bde7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/701615. Important tips:
|
Message from Daniel Maslowski: Patch Set 6: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Daniel Maslowski: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Daniel Maslowski: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Daniel Maslowski: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
This PR (HEAD: 2853629) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/701615. Important tips:
|
Message from Jorropo: Patch Set 20: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 20: Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Go LUCI: Patch Set 20: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-09-18T12:17:55Z","revision":"8b1aeabd4e891ec27f9826c0a0116d0db1335096"} Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 20: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Go LUCI: Patch Set 20: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64-sizespecializedmalloc has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Go LUCI: Patch Set 20: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Daniel Maslowski: Patch Set 20: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 21: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Go LUCI: Patch Set 21: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-09-18T13:10:21Z","revision":"c946ac4e1630f6904fec87d437106675fec65503"} Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Go LUCI: Patch Set 21: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 23: Code-Review+2 (7 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 23: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Linux introduced new syscalls to fix the year 2038 issue. To still be able to use the old ones, the Kconfig option COMPAT_32BIT_TIME would be necessary. Use the new syscall with 64-bit values for futexwakeup by default. Define _ENOSYS for detecting if it's not available. Add a fallback to use the older syscall in case the new one is not available, since Go runs on Linux from 2.6.32 on, per https://go.dev/wiki/MinimumRequirements. Fixes golang#75133
This PR (HEAD: 96dd1bd) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/701615. Important tips:
|
Message from Daniel Maslowski: Patch Set 23: (7 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 24: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 24: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 24: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Go LUCI: Patch Set 24: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-09-18T19:18:21Z","revision":"14f79d5b79d510aea467f2daf020535236fc9b28"} Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 24: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Go LUCI: Patch Set 24: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Go LUCI: Patch Set 24: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 24: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Michael Knyszek: Patch Set 24: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Mark Freeman: Patch Set 24: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Message from Jorropo: Patch Set 24: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701615. |
Linux introduced new syscalls to fix the year 2038 issue. To still be able to use the old ones, the Kconfig option COMPAT_32BIT_TIME would be necessary. Use the new syscall with 64-bit values for futex by default. Define _ENOSYS for detecting if it's not available. Add a fallback to use the older syscall in case the new one is not available, since Go runs on Linux from 2.6.32 on, per https://go.dev/wiki/MinimumRequirements. Updates #75133 Change-Id: I65daff0a3d06b55440ff05d8f5a9aa1c07eb201d GitHub-Last-Rev: 96dd1bd GitHub-Pull-Request: #75306 Reviewed-on: https://go-review.googlesource.com/c/go/+/701615 Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Mark Freeman <markfreeman@google.com> Reviewed-by: Jorropo <jorropo.pgm@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This PR is being closed because golang.org/cl/701615 has been merged. |
Linux introduced new syscalls to fix the year 2038 issue.
To still be able to use the old ones, the Kconfig option
COMPAT_32BIT_TIME would be necessary.
Use the new syscall with 64-bit values for futex by default.
Define _ENOSYS for detecting if it's not available.
Add a fallback to use the older syscall in case the new one is
not available, since Go runs on Linux from 2.6.32 on, per
https://go.dev/wiki/MinimumRequirements.
Updates #75133