errors: add AsType #75621

jub0bs · 2025-09-26T19:13:20Z

Fixes #51945

gopherbot · 2025-09-26T19:23:13Z

This PR (HEAD: 8cb147f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/707235.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-09-26T19:31:12Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-26T19:39:11Z

Message from jub0bs:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-26T20:34:45Z

Message from t hepudds:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-26T20:42:33Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-09-26T20:24:58Z","revision":"9420dd3ed466a26d5a7851c47d324608aeb0837b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-26T20:50:22Z

Message from t hepudds:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-26T20:50:22Z

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Failed Tryjobs:

golang/try/gotip-linux-amd64. Summary (view all results):

go on master (change 707235)

To reproduce, try gomote repro 8702634196345645617.

Additional links for debugging:

go tool dist test -json output [shard 4]

golang/try/gotip-linux-amd64-boringcrypto. Summary (view all results):

go on master (change 707235)

To reproduce, try gomote repro 8702634196345645601.

Additional links for debugging:

go tool dist test -json output [shard 4]

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-26T20:50:23Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-26T20:58:37Z

Message from t hepudds:

Patch Set 1: Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-26T20:58:38Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-09-26T20:49:08Z","revision":"9420dd3ed466a26d5a7851c47d324608aeb0837b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-26T20:58:39Z

Message from t hepudds:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-26T21:06:23Z

Message from t hepudds:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-26T21:06:23Z

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Failed Tryjobs:

golang/try/gotip-linux-amd64-boringcrypto. Summary (view all results):

go on master (change 707235)

To reproduce, try gomote repro 8702632674002459985.

Additional links for debugging:

go tool dist test -json output [shard 3]

golang/try/gotip-linux-amd64_avx512. Summary (view all results):

go on master (change 707235)

To reproduce, try gomote repro 8702632674002459921.

Additional links for debugging:

go tool dist test -json output [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-26T23:22:13Z

Message from Damien Neil:

Patch Set 1:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-27T14:44:08Z

This PR (HEAD: 7835437) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/707235.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-09-27T14:51:30Z

Message from jub0bs:

Patch Set 1:

(9 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-27T15:14:07Z

Message from Jes Cok:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-27T15:14:07Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-09-27T15:03:30Z","revision":"3f2be4f9bd7fe57ca76360eb2049ebdd760e12c4"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-27T15:29:06Z

Message from Jes Cok:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-27T15:29:07Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-27T15:29:07Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-28T12:16:34Z

Message from Sean Liao:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-28T12:54:49Z

Message from jub0bs:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-28T12:54:50Z

Message from jub0bs:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-28T13:28:18Z

Message from Sean Liao:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T13:48:54Z

This PR (HEAD: 73f4ce9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/707235.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-09-29T13:58:40Z

Message from jub0bs:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T15:03:23Z

Message from t hepudds:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T15:03:23Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-09-29T14:54:41Z","revision":"a36568c29ce305359dfcd723877f13e33e5666f0"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T15:21:18Z

Message from t hepudds:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T15:21:19Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T15:21:19Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T15:37:53Z

Message from Damien Neil:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T15:46:01Z

Message from jub0bs:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T15:46:09Z

This PR (HEAD: 05af106) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/707235.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-09-29T16:18:38Z

Message from Sean Liao:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T16:34:22Z

Message from Damien Neil:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T16:34:22Z

Message from Damien Neil:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

Fixes golang#51945

gopherbot · 2025-09-29T16:57:59Z

This PR (HEAD: c6ff335) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/707235.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-09-29T17:06:25Z

Message from jub0bs:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T21:51:22Z

Message from Sean Liao:

Patch Set 5: Code-Review+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T21:51:23Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-09-29T21:39:31Z","revision":"1472b2d45abec79f369a85e24724a0840a7feae5"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T22:08:11Z

Message from Sean Liao:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T22:08:12Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T22:08:12Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-29T23:20:53Z

Message from Damien Neil:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-09-30T17:03:27Z

Message from Carlos Amedee:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/707235.
After addressing review feedback, remember to publish your drafts!

Fixes #51945 Change-Id: Icda169782e796578eba728938134a85b5827d3b6 GitHub-Last-Rev: c6ff335 GitHub-Pull-Request: #75621 Reviewed-on: https://go-review.googlesource.com/c/go/+/707235 Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Damien Neil <dneil@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Sean Liao <sean@liao.dev>

gopherbot · 2025-09-30T17:29:09Z

This PR is being closed because golang.org/cl/707235 has been merged.

austinderek mentioned this pull request Sep 26, 2025

errors: add AsType PullRequestInc/go#87

Closed

jub0bs force-pushed the errors-add-astype branch from 8cb147f to 7835437 Compare September 27, 2025 14:41

jub0bs force-pushed the errors-add-astype branch from 7835437 to 73f4ce9 Compare September 29, 2025 13:46

jub0bs force-pushed the errors-add-astype branch from 73f4ce9 to 05af106 Compare September 29, 2025 15:38

errors: add AsType

c6ff335

Fixes golang#51945

jub0bs force-pushed the errors-add-astype branch from 05af106 to c6ff335 Compare September 29, 2025 16:57

gopherbot closed this Sep 30, 2025

errors: add AsType #75621

errors: add AsType #75621

Conversation

jub0bs commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 26, 2025

Uh oh!

gopherbot commented Sep 27, 2025

Uh oh!

gopherbot commented Sep 27, 2025

Uh oh!

gopherbot commented Sep 27, 2025

Uh oh!

gopherbot commented Sep 27, 2025

Uh oh!

gopherbot commented Sep 27, 2025

Uh oh!

gopherbot commented Sep 27, 2025

Uh oh!

gopherbot commented Sep 27, 2025

Uh oh!

gopherbot commented Sep 28, 2025

Uh oh!

gopherbot commented Sep 28, 2025

Uh oh!

gopherbot commented Sep 28, 2025

Uh oh!

gopherbot commented Sep 28, 2025

Uh oh!

gopherbot commented Sep 29, 2025

Uh oh!

gopherbot commented Sep 29, 2025

Uh oh!

gopherbot commented Sep 29, 2025

Uh oh!

gopherbot commented Sep 29, 2025

Uh oh!

gopherbot commented Sep 29, 2025

Uh oh!

gopherbot commented Sep 29, 2025

Uh oh!

gopherbot commented Sep 29, 2025

Uh oh!

gopherbot commented Sep 29, 2025

Uh oh!

gopherbot commented Sep 29, 2025

Uh oh!

gopherbot commented Sep 29, 2025

Uh oh!

gopherbot commented Sep 29, 2025

Uh oh!

gopherbot commented Sep 29, 2025

Uh oh!

gopherbot commented Sep 29, 2025