-
Notifications
You must be signed in to change notification settings - Fork 18.4k
testing/synctest: fix inverted test failure message in TestContextAfterFunc #75687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5c6f8c0
to
3b06900
Compare
This PR (HEAD: 3b06900) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/708275. Important tips:
|
3b06900
to
2c3f357
Compare
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/708275. |
2c3f357
to
e7e825c
Compare
This PR (HEAD: 2c3f357) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/708275. Important tips:
|
Message from Gopher Robot: Patch Set 2: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/708275. |
This PR (HEAD: e7e825c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/708275. Important tips:
|
Message from Frederic Marand (FGM): Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/708275. |
e7e825c
to
e2c7bc5
Compare
This PR (HEAD: e2c7bc5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/708275. Important tips:
|
e2c7bc5
to
f0d8327
Compare
- Change incorrect failure message Change-Id: I5592becfde6aaca3d7f0e2f09bc7a9785228523e
This PR (HEAD: f0d8327) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/708275. Important tips:
|
Message from Sean Liao: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/708275. |
f0d8327
to
0ff7bd3
Compare
This PR (HEAD: 0ff7bd3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/708275. Important tips:
|
Message from Frederic Marand (FGM): Patch Set 6: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/708275. |
Message from Sean Liao: Patch Set 7: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/708275. |
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-10-01T12:47:22Z","revision":"aaf4a09078277ca188fed3fd108af14c08a1d6b8"} Please don’t reply on this GitHub thread. Visit golang.org/cl/708275. |
Message from Sean Liao: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/708275. |
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/708275. |
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/708275. |
Message from Alan Donovan: Patch Set 7: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/708275. |
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-10-01T14:08:13Z","revision":"aaf4a09078277ca188fed3fd108af14c08a1d6b8"} Please don’t reply on this GitHub thread. Visit golang.org/cl/708275. |
Message from Alan Donovan: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/708275. |
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/708275. |
…erFunc Fixes #75685 Change-Id: I5592becfde6aaca3d7f0e2f09bc7a9785228523e GitHub-Last-Rev: 0ff7bd3 GitHub-Pull-Request: #75687 Reviewed-on: https://go-review.googlesource.com/c/go/+/708275 Reviewed-by: Alan Donovan <adonovan@google.com> Auto-Submit: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Damien Neil <dneil@google.com> Auto-Submit: Sean Liao <sean@liao.dev> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Sean Liao <sean@liao.dev>
This PR is being closed because golang.org/cl/708275 has been merged. |
Fixes #75685