dev: no semaphore if canceled #6128
Merged
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
|
please add a description |
ldez
changed the title
ldez
added
topic: cleanup
|
added a description 🙏🏻 |
|
|
|
You must sign the CLA |
|
done! |
|
I noticed that you are working for Cloudflare. I'm trying to reach companies that use golangci-lint for sponsoring. Could I ask you if you have any contacts to share? You can use the email from our GitHub profile if needed. |
|
Sure, I will loop you in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If context is canceled, we're still trying to acquire a semaphore but it's unnecessary so check context before blocking. This can improve cancelation speed by preventing starvation.