Skip to content

dev: no semaphore if canceled #6128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
Merged

dev: no semaphore if canceled #6128

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b3b28b
refactor: no semaphore if canceled
ferhatelmas Oct 13, 2025
dcb4431
review
ldez Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions pkg/goanalysis/runner_loadingpackage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,13 @@ func (lp *loadingPackage) analyzeRecursive(ctx context.Context, cancel context.C
}

func (lp *loadingPackage) analyze(ctx context.Context, cancel context.CancelFunc, loadMode LoadMode, loadSem chan struct{}) {
loadSem <- struct{}{}
defer func() {
<-loadSem
}()

select {
case <-ctx.Done():
return
default:
case loadSem <- struct{}{}:
defer func() {
<-loadSem
}()
}

// Save memory on unused more fields.
Expand Down
Loading