Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to add the appropriate library directory. #3

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Make sure to add the appropriate library directory. #3

merged 1 commit into from
Dec 7, 2021

Conversation

clalancette
Copy link
Collaborator

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This ensures that the tests run without having to add in LD_LIBRARY_PATH.

@clalancette
Copy link
Collaborator Author

Oh, this one also builds on #1 and #2, but is independent of them. I'll rebase this once those are merged in.

@clalancette
Make sure to add the appropriate library directory.
f1b43a4 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@gonzodepedro gonzodepedro merged commit 143da91 into gonzodepedro:gonzo/non-transform-intra-process-working-tests Dec 7, 2021
clalancette added a commit that referenced this pull request Dec 17, 2021
@clalancette
Make sure to add the appropriate library directory. (#3)
ee9afb6 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
gonzodepedro pushed a commit that referenced this pull request Dec 20, 2021
@clalancette
Add in more of the necessary logic on the publish side. (#2)
faa45d5 
That is, make sure to deal with inter-process publishing properly.
This requires us to introduce two copies of
do_intra_process_and_return_shared(), one of which deals with the
ROS Message type and the other that deals with the PublishedType.
This is kind of wasteful, and we may get rid of this later on,
but this works for now.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

Make sure to add the appropriate library directory. (#3)

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette added a commit that referenced this pull request Dec 20, 2021
@clalancette
Add in more of the necessary logic on the publish side. (#2)
11b7280 
That is, make sure to deal with inter-process publishing properly.
This requires us to introduce two copies of
do_intra_process_and_return_shared(), one of which deals with the
ROS Message type and the other that deals with the PublishedType.
This is kind of wasteful, and we may get rid of this later on,
but this works for now.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

Make sure to add the appropriate library directory. (#3)

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette added a commit that referenced this pull request Jan 4, 2022
@clalancette
Add in more of the necessary logic on the publish side. (#2)
6dc5e4e 
That is, make sure to deal with inter-process publishing properly.
This requires us to introduce two copies of
do_intra_process_and_return_shared(), one of which deals with the
ROS Message type and the other that deals with the PublishedType.
This is kind of wasteful, and we may get rid of this later on,
but this works for now.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

Make sure to add the appropriate library directory. (#3)

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonzodepedro gonzodepedro Awaiting requested review from gonzodepedro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @gonzodepedro