Skip to content

armmer01 #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

armmer01 #652

wants to merge 1 commit into from

Conversation

@ghost
Copy link

@ghost ghost commented Dec 17, 2024 •
edited by ghost
Loading

…i/types/Natthachai-arm/generative-ai-python

Description of the change

Motivation

Type of change

Choose one: (Bug fix | Feature request | Documentation | Other)

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

Rename google/generativeai/types/model_types.py to google/generativea…
59169a3 
…i/types/Natthachai-arm/generative-ai-python
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Dec 17, 2024
ghost
ghost commented Dec 28, 2024
View reviewed changes
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix type definitions and imports for generative AI models

ghost
ghost commented Feb 3, 2025
View reviewed changes
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test.yml

@ghost ghost changed the title Rename google/generativeai/types/model_types.py to google/generativea… armmer01 Feb 3, 2025
ghost
ghost commented Feb 3, 2025
View reviewed changes
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change

ghost
ghost commented Feb 3, 2025
View reviewed changes
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

google/generativeai/types/model_types.py

@ghost ghost marked this pull request as draft February 20, 2025 03:10
@ghost ghost requested a review from Jacksonearl2468 February 20, 2025 03:10
@ghost ghost marked this pull request as ready for review February 20, 2025 03:10
@MarkDaoust MarkDaoust closed this Feb 20, 2025
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Feb 20, 2025
@ghost ghost deleted the patch-1 branch February 21, 2025 12:17
@ghost ghost restored the patch-1 branch February 21, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jacksonearl2468 Jacksonearl2468 Awaiting requested review from Jacksonearl2468

Assignees

No one assigned

Labels

component:python sdk Issue/PR related to Python SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jacksonearl2468 @MarkDaoust