Add support for specifying latest for version
#45
Conversation
craigdbarber
requested review from
donmccasland,
averikitsch and
stephenashank
craigdbarber
force-pushed
the
latest-version
branch
3 times, most recently
from
561aca4
to
e72495c
Compare
craigdbarber
force-pushed
the
latest-version
branch
from
e72495c
to
7dbfdef
Compare
craigdbarber
force-pushed
the
latest-version
branch
from
2ba2532
to
67582b3
Compare
setup-gcloud/src/version-util.ts
Outdated
| @@ -0,0 +1,52 @@ | |||
| /* | |||
| * Copyright 2019 Google LLC | |||
There was a problem hiding this comment.
You caught me copying and pasting :)
Done.
| @@ -0,0 +1,30 @@ | |||
| /* | |||
| * Copyright 2019 Google LLC | |||
setup-gcloud/src/version-util.ts
Outdated
| */ | ||
| export async function getLatestGcloudSDKVersion(): Promise<string> { | ||
| const client: httpm.HttpClient = new httpm.HttpClient( | ||
| 'github-actions-setup-gcloud', |
There was a problem hiding this comment.
Can we pass this in from the other fie where it is defined?
setup-gcloud/src/version-util.ts
Outdated
| .get( | ||
| 'https://api.github.com/repos/GoogleCloudPlatform/cloud-sdk-docker/tags', | ||
| ) | ||
| .then(res => { |
There was a problem hiding this comment.
Can we change this to async/await pattern to stay consistent?
There was a problem hiding this comment.
I would love to, sadly the library we're using here doesn't support it, so we have to wrap around it :)
There was a problem hiding this comment.
I'm seeing async/await in their "docs" aka tests (https://github.com/microsoft/typed-rest-client/blob/master/test/tests/httptests.ts#L52). This code is just getting harder and harder to read.
There was a problem hiding this comment.
Oh snap! You are correct. For some reason when I first looked into using the library I had decided it didn't support it. Glad to see that's not the case. Good catch!
craigdbarber
force-pushed
the
latest-version
branch
2 times, most recently
from
e6b55fa
to
c84e09e
Compare
craigdbarber
force-pushed
the
latest-version
branch
from
c84e09e
to
6102f1d
Compare
Integration tests successfully passed: https://github.com/GoogleCloudPlatform/github-actions/actions/runs/32798521
Addresses: #31