Skip to content

Conversation

snazzybytes
Copy link
Contributor

Stumbled upon another broken link. Courtesy fix 🫡

Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciated! We've had some discussions about linting for these, but it's not clear how to do so easily.

@djmitche djmitche merged commit 32b5a19 into google:main Jun 17, 2024
@snazzybytes snazzybytes deleted the channels-broken-link branch June 20, 2024 22:54
mgeisler pushed a commit that referenced this pull request Jul 22, 2024
In #2153 I aimed to fix a link but broke it.
In this PR, I fix it and add
[`mdbook-linkcheck`](https://github.com/Michael-F-Bryan/mdbook-linkcheck)
to avoid future cases.

Some past fixes that could have been prevented, in addition to mine in
this PR:
* #811
* #2064
* #2146

Note:  
`mdbook-linkcheck` may also check external links with a configuration
change.
It can be beneficial to check also external links from time to time. I
ran it here and found 3 broken links.

Maintainers - sorry for the lack of a preceding issue. We can discuss it
here.
Some remaining work is to fix the outdated internal links in the
translations, not done here.
Let me know what you think about the proposed contribution.

This PR completes #1502.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants