Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

make date required default true for new realms #1033

Merged
merged 4 commits into from
Nov 10, 2020
Merged

make date required default true for new realms #1033

merged 4 commits into from
Nov 10, 2020

Conversation

mikehelmick
Copy link
Contributor

Proposed Changes

  • Make date required the default for new realms to encourage usage of this feature.

Release Note

"date required" is the default setting on NEW realms only. Existing realms not changed on upgrade.

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Nov 10, 2020
sethvargo
sethvargo approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

whaught
whaught approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@whaught whaught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@whaught
Copy link
Contributor

whaught commented Nov 10, 2020

/retest

1 similar comment
@mikehelmick
Copy link
Contributor Author

/retest

@mikehelmick
Copy link
Contributor Author

the test failure is relevant .. just a moment

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,sethvargo,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 55bff33 into google:main Nov 10, 2020
@mikehelmick mikehelmick deleted the flipityFlop branch November 10, 2020 17:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@yegle yegle Awaiting requested review from yegle

2 more reviewers

@sethvargo sethvargo sethvargo approved these changes

@whaught whaught whaught approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sethvargo sethvargo

@whaught whaught

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikehelmick @whaught @google-oss-robot @sethvargo