This repository was archived by the owner on Jul 12, 2023. It is now read-only.
Lookup realm before passing in ID #1185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
whaught
reviewed
Nov 24, 2020
pkg/controller/admin/events.go
Outdated
| } | ||
|
|
||
| if realm, err = c.db.FindRealm(realmID); err != nil { | ||
| scopes = append(scopes, database.WithAuditRealmID(realmID)) |
There was a problem hiding this comment.
realm, err = c.db.FindRealm(realmID)
scopes = append(scopes, database.WithAuditRealmID(realm.ID))
I think this would be the same without needing interface{} params necessarily
There was a problem hiding this comment.
Yea, but that adds another db call and I think it leaks the existence of a realm
sethvargo
force-pushed
the
sethvargo/intconv
branch
from
03298fb to
2ed4113
Compare
sethvargo
force-pushed
the
sethvargo/intconv
branch
from
2ed4113 to
e7579b2
Compare
sethvargo
changed the title
whaught
approved these changes
Nov 24, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/google/exposure-notifications-verification-server/security/code-scanning/7
Release Note
/assign @whaught