Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

Terraform for appsync #1243

Merged
merged 5 commits into from
Dec 2, 2020
Merged

Terraform for appsync #1243

merged 5 commits into from
Dec 2, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Dec 2, 2020

Fixes ##1092

Proposed Changes

  • Add terraform config for the appsync service
    • Looks a lot like the cleanup service. Another option would to be to make this a route of cleanup.
  • Adds the appropriate URL for json

Release Note

Add terraform for setting up the mobile-app-sync cloud run service, scheduling, and URL config

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 2, 2020
@whaught whaught removed the request for review from jeremyfaller December 2, 2020 21:18
sethvargo
sethvargo reviewed Dec 2, 2020
View reviewed changes
Copy link
Contributor

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run terraform fmt too please?

terraform/service_appsync.tf Outdated

resource "google_service_account" "appsync" {
project = var.project
account_id = "en-verification-appsync-sa"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limit is 20 chars

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exposure-notifications-verification-server/terraform/service_cleanup.tf

Line 17 in 1451864

account_id = "en-verification-cleanup-sa"

are these existing values okay?

terraform/service_appsync.tf Outdated

resource "google_service_account" "appsync-invoker" {
project = data.google_project.project.project_id
account_id = "en-appsync-invoker-sa"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same note, 20 chars

sethvargo
sethvargo approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 52e578a into google:main Dec 2, 2020
@whaught whaught deleted the schedule-sync branch December 3, 2020 21:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yegle yegle Awaiting requested review from yegle

1 more reviewer

@sethvargo sethvargo sethvargo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whaught @google-oss-robot @sethvargo @googlebot