Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

Use the new batch API for the bulk uploader #1277

Merged
merged 3 commits into from
Dec 5, 2020
Merged

Use the new batch API for the bulk uploader #1277

merged 3 commits into from
Dec 5, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Dec 5, 2020 •
edited
Loading

Proposed Changes

  • Uses the new batch-issue API for bulk code issaunce
    • Batch size is 10 which should 10x the throttle on requests
  • Start at 1 instead of 0 for line - non CS people probably start there.

Release Note

Move the Bulk Issue Codes UI to use the batch API

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 5, 2020
sethvargo
sethvargo approved these changes Dec 5, 2020
View reviewed changes
Copy link
Contributor

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Can we move this into application.js as a follow-up? Looks like the only Go-template dependency is the csrf token, and we already pull that in js from the meta tag.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 5d06ebe into google:main Dec 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2020
@whaught whaught deleted the use-batch-api branch December 7, 2020 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yegle yegle Awaiting requested review from yegle

1 more reviewer

@sethvargo sethvargo sethvargo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mikehelmick mikehelmick

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whaught @google-oss-robot @sethvargo @mikehelmick