This repository was archived by the owner on Jul 12, 2023. It is now read-only.
Filter user search to system admins #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mikehelmick
reviewed
Nov 6, 2020
| Order("LOWER(name) ASC") | ||
|
|
||
| if systemAdminOnly { | ||
| query = query.Where("system_admin IS TRUE") |
There was a problem hiding this comment.
does this work?
will have system_admin IS FALSE followed by sytem_admin is true
better to make systemAdminOnly a param to the query?
There was a problem hiding this comment.
Sorry I think that was a merge conflict with: #985
mikehelmick
approved these changes
Nov 6, 2020
mikehelmick
approved these changes
Nov 6, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #975
Proposed Changes
Release Note