Show pills for realm/system admin #985
Conversation
google-cla
bot
added
the
cla: yes
| {{.Name}} | ||
| {{if .Admin}} | ||
| <span class="ml-1 badge badge-pill badge-primary">System admin</span> | ||
| {{else if .IsRealmAdmin}} |
There was a problem hiding this comment.
I don't think this is if/else, a single user could be both
There was a problem hiding this comment.
Idk if that's useful. A System Admin is likely both (and can join any realm as admin), so it seems a little redundant to show both.
There was a problem hiding this comment.
I think it's useful to show which realms a person is admin and member of
There was a problem hiding this comment.
We will, but in this list it would be hard to show all the realm names etc.
This will become a link to a detail page (that looks more similar to the My Account page with a list of realms)
There was a problem hiding this comment.
my vote is the same as seth - show both pills in that case
There was a problem hiding this comment.
well that's 2-1 then. Both pills shown.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #975
Proposed Changes