Skip to content

Fix null checks and assertions for visibility_detector (#354) #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022
Merged

Fix null checks and assertions for visibility_detector (#354) #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/visibility_detector/lib/src/visibility_detector_layer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ class VisibilityDetectorLayer extends ContainerLayer {

/// Computes the accumulated clipping bounds, in global coordinates.
Rect _computeClipRect() {
assert(RendererBinding.instance.renderView != null);
var clipRect = Offset.zero & RendererBinding.instance.renderView.size;
assert(RendererBinding.instance?.renderView != null);
var clipRect = Offset.zero & RendererBinding.instance!.renderView.size;

var parentLayer = parent;
while (parentLayer != null) {
Expand Down Expand Up @@ -167,7 +167,7 @@ class VisibilityDetectorLayer extends ContainerLayer {
if (isFirstUpdate) {
// We're about to render a frame, so a post-frame callback is guaranteed
// to fire and will give us the better immediacy than `scheduleTask<T>`.
SchedulerBinding.instance.addPostFrameCallback((timeStamp) {
SchedulerBinding.instance!.addPostFrameCallback((timeStamp) {
_processCallbacks();
});
}
Expand All @@ -190,7 +190,7 @@ class VisibilityDetectorLayer extends ContainerLayer {
// of `addPostFrameCallback` or `scheduleFrameCallback` so that work will
// be done even if a new frame isn't scheduled and without unnecessarily
// scheduling a new frame.
SchedulerBinding.instance
SchedulerBinding.instance!
.scheduleTask<void>(_processCallbacks, Priority.touch);
}

Expand Down