Skip to content

Fixes #361, where Flutter SDK upgrade impacted nullability requirements #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2022
Merged

Fixes #361, where Flutter SDK upgrade impacted nullability requirements #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@
Google Inc.
Abhijeeth Padarthi <rkinabhi@gmail.com>
Alex Li <alexv.525.li@gmail.com>
Clay Harris <rcharris42@gmail.com>
4 changes: 2 additions & 2 deletions ...ages/scrollable_positioned_list/example/test/scrollable_positioned_list_example_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import 'package:scrollable_positioned_list_example/main.dart';

void main() {
setUp(() {
WidgetsBinding.instance.renderView.configuration = TestViewConfiguration(
size: const Size(800, 900), window: RendererBinding.instance.window);
WidgetsBinding.instance!.renderView.configuration = TestViewConfiguration(
size: const Size(800, 900), window: RendererBinding.instance!.window);
});

testWidgets('Start at 0', (WidgetTester tester) async {
Expand Down
2 changes: 1 addition & 1 deletion packages/scrollable_positioned_list/lib/src/positioned_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ class _PositionedListState extends State<PositionedList> {
void _schedulePositionNotificationUpdate() {
if (!updateScheduled) {
updateScheduled = true;
SchedulerBinding.instance.addPostFrameCallback((_) {
SchedulerBinding.instance!.addPostFrameCallback((_) {
if (registeredElements.value == null) {
updateScheduled = false;
return;
Expand Down
4 changes: 2 additions & 2 deletions packages/scrollable_positioned_list/lib/src/scrollable_positioned_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ class _ScrollablePositionedListState extends State<ScrollablePositionedList>
}
if (_isTransitioning) {
_stopScroll(canceled: true);
SchedulerBinding.instance.addPostFrameCallback((_) {
SchedulerBinding.instance!.addPostFrameCallback((_) {
_startScroll(
index: index,
alignment: alignment,
Expand Down Expand Up @@ -482,7 +482,7 @@ class _ScrollablePositionedListState extends State<ScrollablePositionedList>
final startCompleter = Completer<void>();
final endCompleter = Completer<void>();
startAnimationCallback = () {
SchedulerBinding.instance.addPostFrameCallback((_) {
SchedulerBinding.instance!.addPostFrameCallback((_) {
startAnimationCallback = () {};

opacity.parent = _opacityAnimation(opacityAnimationWeights).animate(
Expand Down
2 changes: 1 addition & 1 deletion packages/scrollable_positioned_list/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: scrollable_positioned_list
version: 0.3.0
version: 0.3.1
description: >
A list with helper methods to programmatically scroll to an item.
homepage: https://github.com/google/flutter.widgets/tree/master/packages/scrollable_positioned_list
Expand Down
2 changes: 1 addition & 1 deletion packages/scrollable_positioned_list/test/scrollable_positioned_list_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1279,7 +1279,7 @@ void main() {
await setUpWidgetTest(tester, itemPositionsListener: itemPositionsListener);

final root = WidgetsBinding
.instance.pipelineOwner.semanticsOwner!.rootSemanticsNode!;
.instance!.pipelineOwner.semanticsOwner!.rootSemanticsNode!;

final semanticNodes = <SemanticsNode>[root];

Expand Down