The Tree API does not allow for file deletion

[dandonovsc]

In order to delete a file via the Github REST API v3 a file's sha need to be null as per the documentation

The SHA1 checksum ID of the object in the tree. Also called tree.sha. If the value is null then the file will be deleted.

The library's implementation defines the sha field as a pointer to a string with that will be ignored when json serialized:

type TreeEntry struct {
	SHA     *string 'json:"sha,omitempty"'
         ................
}

When submitting a POST request to the repos/%v/%v/git/trees API with no sha and no content validation fails with response 422 Must supply tree.sha or tree.content []

Please advise how a file should be deleted using the library

[gmlewis]

Thank you, @dandonovsc, for the report.

It seems to me that the correct fix for this would be to check if both tree.content and tree.sha are empty, then use a different internal struct where the ,omitempty has been removed from the SHA field which will then pass the null along and thereby delete the file.

Instead of opening this up to our volunteers, I'll write up my thoughts in a PR since I recently did something similar in #1357.